Fixes labscript-suite#16, routines not reordering correctly with GUI buttons.

Problem was confusing a passive transformation with an active transformation:

passive transformation: constructing a new list from a list of indices saying
where in the old list each item should come from (what we were doing)

active transformation: constructing a new list out of a list of indices for
where in the new list items in the old list should be moved to (what we should
have been doing)

When a single routine was moved, this simply swapped it with the one above or
below it and so a passive and active transformation of the order are identical.
But for reordering multiple routines at once it gave the wrong result.

Author: chrisjbillington

__main__.py

@@ -717,8 +717,11 @@ def reorder(self, order):
             name_item.setData(new_index, self.ROLE_SORTINDEX)
         self.ui.treeView.sortByColumn(self.COL_NAME, QtCore.Qt.AscendingOrder)
         # Apply new order to our list of routines too:
-        self.routines = [self.routines[i] for i in order]
-        
+        reordered_routines = [None]*len(order)
+        for routine, index in zip(self.routines, order):
+            reordered_routines[index] = routine
+        self.routines = reordered_routines
+
     def update_select_all_checkstate(self):
         with self.select_all_checkbox_state_changed_disconnected:
             all_states = []