Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fault_orientations #180

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Fix/fault_orientations #180

merged 3 commits into from
Jan 15, 2025

Conversation

rabii-chaarani
Copy link
Member

Description

Should use Datatype.FAULT_ORIENTATION instead of Datatype.STRUCTURE

Fixes #(issue)

Type of change

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Test improvement

How Has This Been Tested?

Please describe any tests that you ran to verify your changes.
Provide branch name so we can reproduce.

Checklist:

  • This branch is up-to-date with master
  • All gh-action checks are passing
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My tests run with pytest from the map2loop folder
  • New and existing tests pass locally with my changes

Checklist continued (if PR includes changes to documentation)

  • I have built the documentation locally with make.bat
  • I have built this documentation in docker, following the docker configuration in map2loop/docs
  • I have checked my spelling and grammar

@rabii-chaarani rabii-chaarani merged commit 21b766e into master Jan 15, 2025
2 checks passed
rabii-chaarani added a commit that referenced this pull request Jan 20, 2025
* fix: add featureId when parsing fault_orientations

* chore(master): release 3.2.2 (#178)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: use FAULT_ORIENTATION instead of STRUCTURE

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants