Sound Engine crash debugging

Author: LostLuma

platforms/common/src/main/java/dynamic_fps/impl/DynamicFPSMod.java

@@ -25,8 +25,10 @@
 import net.minecraft.client.Minecraft;
 import net.minecraft.client.gui.screens.LoadingOverlay;
 import net.minecraft.client.gui.screens.Screen;
+import net.minecraft.client.resources.sounds.SimpleSoundInstance;
 import net.minecraft.network.chat.Component;
 import net.minecraft.resources.ResourceLocation;
+import net.minecraft.sounds.SoundEvents;
 import net.minecraft.sounds.SoundSource;
 
 import org.jetbrains.annotations.Nullable;
@@ -66,6 +68,19 @@ public static void init() {
 		Version version = platform.getModVersion(Constants.MOD_ID).orElseThrow();
 
 		Logging.getLogger().info("Dynamic FPS {} active on {}!", version, platform.getName());
+
+		// Thread.ofPlatform().name("worstie's-thread").start(DynamicFPSMod::playSoundOffthread);
+	}
+
+	private static void playSoundOffthread() {
+		try {
+			Thread.sleep(5000);
+		} catch (InterruptedException e) {
+			Thread.interrupted();
+			return;
+		}
+
+		minecraft.getSoundManager().play(SimpleSoundInstance.forUI(SoundEvents.UI_BUTTON_CLICK, 1.0F));
 	}
 
 	public static boolean disabledByUser() {

platforms/common/src/main/java/dynamic_fps/impl/mixin/debug/SoundEngineMixin.java

@@ -0,0 +1,56 @@
+package dynamic_fps.impl.mixin.debug;
+
+import dynamic_fps.impl.util.Logging;
+import net.minecraft.client.Minecraft;
+import net.minecraft.client.sounds.SoundEngine;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.Unique;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Inject;
+import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
+import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
+
+@Mixin(SoundEngine.class)
+public class SoundEngineMixin {
+	@Inject(method = "updateCategoryVolume", at = @At("HEAD"))
+	private void updateCategoryVolume(CallbackInfo callbackInfo) {
+		dynamic_fps$logOffThreadUsage("updateCategoryVolume");
+	}
+
+	@Inject(method = "stop", at = @At("HEAD"))
+	private void stop(CallbackInfo callbackInfo) {
+		dynamic_fps$logOffThreadUsage("stop");
+	}
+
+	@Inject(method = "stopAll", at = @At("HEAD"))
+	private void stopAll(CallbackInfo callbackInfo) {
+		dynamic_fps$logOffThreadUsage("stopAll");
+	}
+
+	@Inject(method = "tickNonPaused", at = @At("HEAD"))
+	private void tickNonPaused(CallbackInfo callbackInfo) {
+		dynamic_fps$logOffThreadUsage("tickNonPaused");
+	}
+
+	@Inject(method = "isActive", at = @At("HEAD"))
+	private void isActive(CallbackInfoReturnable<Boolean> cir) {
+		dynamic_fps$logOffThreadUsage("isActive");
+	}
+
+	@Inject(method = "play", at = @At("HEAD"))
+	private void play(CallbackInfo callbackInfo) {
+		dynamic_fps$logOffThreadUsage("play");
+	}
+
+	@Inject(method = "playDelayed", at = @At("HEAD"))
+	private void playDelayed(CallbackInfo callbackInfo) {
+		dynamic_fps$logOffThreadUsage("playDelayed");
+	}
+
+	@Unique
+	private void dynamic_fps$logOffThreadUsage(String method) {
+		if (!Minecraft.getInstance().isSameThread()) {
+			Logging.getLogger().warn("Potentially dangerous call to SoundEngine.{} from non-main thread!", method, new Throwable());
+		}
+	}
+}

platforms/common/src/main/resources/dynamic_fps-common.mixins.json

@@ -12,7 +12,8 @@
         "SoundEngineMixin",
         "ToastComponentMixin",
         "WindowMixin",
-        "bugfix.BlockableEventLoopMixin"
+        "bugfix.BlockableEventLoopMixin",
+        "debug.SoundEngineMixin"
     ],
     "mixins": [],
     "server": [],