feat: support partial_attr for struct fields
#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschey
force-pushed
the
feat/partial-attrs
branch
from
10da986 to
aa10700
Compare
aschey
force-pushed
the
feat/partial-attrs
branch
from
aa10700 to
843ba9e
Compare
aschey
commented
Apr 6, 2025
| @@ -48,6 +48,7 @@ toml = { version = "0.8", optional = true } | |||
|
|
|||
| [dev-dependencies] | |||
| pretty_assertions = "1.2.1" | |||
| derive_more = { version = "2.0.1", features = ["debug"] } | |||
There was a problem hiding this comment.
I unfortunately had to add a new dev dependency just for the test because I couldn't think of any derive macros in the standard library that use attributes on struct fields.
aschey
force-pushed
the
feat/partial-attrs
branch
from
843ba9e to
bf7583b
Compare
aschey
changed the title
partial_attr for struct fields
aschey
force-pushed
the
feat/partial-attrs
branch
from
bf7583b to
46e661e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #19
This adds support for the existing derive attribute
partial_attrin struct fields. This is useful if you need to derive something on the generated partial struct that requires specifying attributes on struct fields. Being able to derive clap's traits on the partial structs is the main motivation for this, but it also works for any other trait (derive_more is the example I chose for the test).This is most of the work required to support using partial structs with clap. More info in this comment: #19 (comment)