Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y_t, o_pre concat order issure ? #2

Open
science-dojo opened this issue Apr 28, 2019 · 1 comment
Open

Y_t, o_pre concat order issure ? #2

science-dojo opened this issue Apr 28, 2019 · 1 comment

Comments

@science-dojo
Copy link

Nice work!
The version of implementation can reach 22+ BLUE score. However, my implementation have only 0.16+ BLUE score on test dataset. Comparing with your work, I found changing the concatenation torch.cat((Y_t, o_pre), dim=1) to torch.cat((o_pre, Y_t), dim=1) can only reach 0.16+ BLUE score.

Would you like share your ideas why concatenating Y_t and o_pre in such way?

Thank you!

@Luvata
Copy link
Owner

Luvata commented Apr 28, 2019

Thank you for your kind words !
In my opinion, I think the order of features in that case doesn't affect the performance of model. With my implementation, imagine that (Y_t, o_prev) has corresponding weights (W_y, W_o)
Then after finished training, if I change the order into (o_prev, Y_t), and also changing the order of weights into (W_o, W_y), then the output are the same : Y_t * W_y + o_prev * W_o = o_prev * W_o + Y_t * W_y
But if you use your order and train from start, I think your model has different performance just because that order (which affect the initial weight corresponding to (o_prev, Y_t)) doesn't work well with the default random seed.
You can try training a little longer, or set a different random seed and tell me your BLEU score that you have ! 💪

@Luvata Luvata closed this as completed Apr 29, 2019
@Luvata Luvata added the help wanted Extra attention is needed label Nov 16, 2019
@Luvata Luvata reopened this Nov 16, 2019
@Luvata Luvata removed the help wanted Extra attention is needed label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants