You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems the version picker doesn't handle custom domains correctly, and always produces root/version links, instead of (in my case) root/repo.jl/version. Demo here: https://www.evetion.nl/GeoDataFrames.jl/dev/
The following code is used to generate the base url:
Certainly! The assumption seems to be that GitHub has a repo part, and custom domains don't (as in your examples). Maybe the deploy url should just be taken into account, instead of parsing the current window url.
edit: Although using deploy url broke the website for me 😅
I have made some changes to this on my branch #246 because I wanted to check everything was working on my fork which automatically uses my account's domain. We could also pull those out of that PR to have things separated better.
It seems the version picker doesn't handle custom domains correctly, and always produces
root/version
links, instead of (in my case)root/repo.jl/version
. Demo here: https://www.evetion.nl/GeoDataFrames.jl/dev/The following code is used to generate the base url:
It seems the function should
removeimprove the check forgithub.io
.The text was updated successfully, but these errors were encountered: