Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT-9,14] Selector 컴포넌트 MenuList로 변경, Chip 컴포넌트 구현 #15

Merged
merged 14 commits into from
Jan 27, 2025

Conversation

qwer0114
Copy link
Contributor

📝 PR 내용

  • Selector → MenuIList 컴포넌트로 변경
  • Selector.Item → TextMenu, Checkbox, DropdownMenu 컴포넌트로 분리
  • Chip 컴포넌트 구현

✅ 작업 내용

  • 기존 Selector 컴포넌트를 Figma에서 메뉴로 명명되있어 추후 혼란을 대비해 이름을 변경했습니다
  • 기존 Selctor의 합성 컴포넌트로 Selector.Item 구성했던 메뉴 아이템들을 각각 menu-items 폴더 아래 check-box, dropdown-menu, text-menu로 분리했습니다
  • Chip 컴포넌트 구현했습니다
    • 구현 모습은 스토리북 참고해주세요

🤔 고민 했던 부분 (선택)

  • Chip 컴포넌트는 이슈 단위가 작아 2개의 이슈를 하나의 pr에 올립니다

🔗 연관 이슈

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maru-egg-fe-v2-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 4:55am

Copy link

🚀 Storybook 링크: https://6789e91d8356b60e6b422469-rmdvcjjiqd.chromatic.com/

@swgvenghy swgvenghy merged commit 4798900 into main Jan 27, 2025
4 of 5 checks passed
@qwer0114 qwer0114 deleted the feature-#9 branch January 29, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - Chip 컴포넌트 구현 [FEAT] - 기존 Selector 컴포넌트 메뉴 컴포넌트로 변경
2 participants