-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Zarrtraj #157
Register Zarrtraj #157
Conversation
mdakits/zarrtraj/metadata.yaml
Outdated
python_requires: ">=3.10" | ||
|
||
## str: a specification for the range of MDAnalysis versions supported by this MDAKit | ||
mdanalysis_requires: ">=2.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only works with 2.7.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just changed this, tests can pass going back to 2.1.0, so will update here and make the change in the next zarrtraj release
mdakits/zarrtraj/metadata.yaml
Outdated
|
||
## str: the development status of the MDAKit | ||
## See https://pypi.org/classifiers/ for development status classifiers. | ||
development_status: Beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must conform to https://pypi.org/classifiers/
The "latest" test is failing. I haven't had time to look into it but this should pass first. |
Yes, saw that. This is the ghost in the machine moto duplicate keys with Zarr issue that is driving me insane. I can recreate it locally if I pip install zarrtraj[test] but I can't recreate it if I install the exact same set of dependencies locally via conda since they're resolved in a slightly different way. It only affects a moto AWS server, not an actual AWS bucket. Edit: tried recreating the issue in a script in an environment the test fails in and could not recreate it. I'm convinced this only occurs within pytest but I have no idea why. Set the tests to skip for now since this doesn't significantly affect test coverage and it won't affect users I'll do another release and once conda forge gets updated these tests will pass |
@orbeckst ready for review, whenever you get a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me — happy to register it! 🎉
Zarrtraj available at
https://github.com/conda-forge/zarrtraj-feedstock
https://pypi.org/project/zarrtraj/