Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM Slip tests #791

Merged
merged 7 commits into from
Feb 1, 2025
Merged

Add IBM Slip tests #791

merged 7 commits into from
Feb 1, 2025

Conversation

haochey
Copy link
Contributor

@haochey haochey commented Jan 21, 2025

Description

This PR adds a few test cases for slip IBM.

Type of change

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Test Configuration: Repeat the IBM tests with "Slip" true.

  • What computers and compilers did you use to test this: MacOS

@haochey haochey requested a review from a team as a code owner January 21, 2025 16:26
@haochey haochey added enhancement New feature or request and removed enhancement New feature or request labels Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.74%. Comparing base (43812d8) to head (59fa254).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   43.72%   43.74%   +0.01%     
==========================================
  Files          65       65              
  Lines       19035    19039       +4     
  Branches     2331     2332       +1     
==========================================
+ Hits         8324     8328       +4     
+ Misses       9304     9303       -1     
- Partials     1407     1408       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson
Copy link
Member

@haochey will you fix the Frontier problem?

@haochey
Copy link
Contributor Author

haochey commented Jan 26, 2025

@haochey will you fix the Frontier problem?

@sbryngelson Yes, I will work on this once my OCLF account and RSA token is enabled.

@haochey haochey requested a review from a team as a code owner January 29, 2025 22:25
Copy link
Contributor

@anandrdbz anandrdbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes to Haocheng for slip cases; should be good to go

@sbryngelson
Copy link
Member

Will merge once benchmarking passes, thanks @haochey !

@sbryngelson sbryngelson merged commit 131b41e into MFlowCode:master Feb 1, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants