Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugging hyper schemes #796

Closed
wants to merge 596 commits into from
Closed

debugging hyper schemes #796

wants to merge 596 commits into from

Conversation

mcarcana
Copy link
Contributor

@mcarcana mcarcana commented Feb 3, 2025

Description

Current implementation of hyperelasticity results in ICFL is NaN for all num_dim cases

Type of change

-[ ] cleaner scheme of hyperelasticity
-[ ] examples added that will become unit tests

Scope

  • MFCv5 upgrading physics features

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

  • examples/1D_hyper_1material
  • examples/1D_hyper_2materials
  • examples/2D_hyper_1material
  • examples/2D_hyper_2materials
  • examples/3D_hyper_1material
  • examples/3D_hyper_2materials

Test Configuration:

  • What computers and compilers did you use to test this: Oscar (cpus only so far)

Checklist

  • I have added comments for the new code"
  • I cannot think of a way to condense this code and reduce any introduced additional line count

mrodrig6 added 30 commits July 7, 2024 17:22
@mrodrig6
retesting for the synchronization error, compiles and passes test suite
4d14ae8
@mrodrig6
HLLC + hypo + 6equation, operational
7b6656e
@mrodrig6
rearranging the btensor calculation
c9a7f11
@mrodrig6
CTR midterm working code
0ea271d
@mrodrig6
merged code with Delta
282f856
@mrodrig6
Merge branch 'MFlowCode:master' into source
8f6c7cb
@mrodrig6
moved code around
2f30581
@mrodrig6
added additional changes in preparation for merger
07563ac
@mrodrig6
Merge branch 'hyperelasticity' of https://github.com/ComputationalFlo…
a1dc73b 
…wGroup/MFC into hyperelasticity
@mrodrig6
made necessary changes to streamline code, compiles on CPUs, not tested
8f8655b
@mrodrig6
cleaned up code in conservative to primitive variables, more changes …
5b04d7d 
…needed, compiles
@mrodrig6
test suite passes on CPUs, testing GPUs
bfb2752
@mrodrig6
refactoring hyperelasticity mostly complete, not yet testing, compile…
ebb1d2e 
…s on CPUs, passes CPU test suite
@mrodrig6
code compiles and passes test suite on Delta GPUs
c7ffbd1
@mrodrig6
reworked \tau evaluation in the common code for hyperelasticity, comp…
0ad7688 
…iles and tests on CPUs
@mrodrig6
debugged pre and post-process on CPUs, testing on GPUs
62b7f56
@mrodrig6
debugged pre and post_process, now investigating btensor calc and cau…
04564ec 
…chy tensor calc
@mrodrig6
debugged issue for the cauchy tensor update
f001949
@mrodrig6
last check of the code, before moving xi calcs to simulation and out …
81a3ae7 
…of pre and post process
@mrodrig6
hypoelasticity can now do grid stretching, building up hyper to do th…
b1556d8 
…e same
@mrodrig6
improved hypo for acc and fixed shear modulus limit
2f30499
@mrodrig6
data issue, checking on Oscar
7491445
@mrodrig6
fixed the ACC commands for grid stretching of hypo
b9c0102
@mrodrig6
merging RMT code into hyperelastic module in simulation, not yet done…
d223e41 
… towards compilation
@mrodrig6
upgraded RMT hyperelastic code, need to integrate to m_rhs
c4779cb
@mrodrig6
debugged hyper for grid stretching, improved ACC looping for hypo
c921cdd
@mrodrig6
hypo passes test suite on Delta GPU, phase change tolerance could be …
481702e 
…reduced for speed
@mrodrig6
fixed hyperelastic stress update call, one more hyper bug remains
9933f80
@mrodrig6
additional modifications for RMT
8476ff5
@mrodrig6
code compiles, passes test suite, hyperelastic RMT runs
a2fd00f
ChrisZYJ and others added 26 commits January 20, 2025 00:28
@ChrisZYJ
Hyper edits (#2)
619e9f1 
* fix checker

* tau_wrt

* misc changes

* lint
@ChrisZYJ
Fix tau_wrt test bug (#3)
4a63dc2 
fix tau_wrt test bug
@ChrisZYJ
fix hyper_model & examples
517ecb5
@ChrisZYJ
fix hyper_model & examples (#4)
f964392
@mrodrig6
corrected the Oscar mako file
b5f5301
@mrodrig6
Merge branch 'master' of https://github.com/ComputationalFlowGroup/MFC
7dd3269
@ChrisZYJ @mrodrig6
change fd_order checker (#5)
db78f42 
Co-authored-by: Mauro Rodriguez Jr <mauro_rodriguez@brown.edu>
@mcarcana
basic 1D/2D hyperelasticity scheme added
7922dcc
@mcarcana
removed print statements in 2d hyper
0834716
@mcarcana
removed print statements from m_hyperelastic part 2
32141de
@mcarcana
corrected double precision intrinsics in m_hyper
52ba7d5
@mcarcana
corrected double precision intrinsics in m_hyper part 2
aa9a007
@mcarcana
actually corrected double precision intrinsics in m_hyper part 3
20d84ec
@mcarcana
Merge branch 'master' into 1d2dhyper
8574011
@mrodrig6
Merge branch 'MFlowCode:master' into master
11754c6
@mrodrig6
Merge branch 'MFlowCode:master' into master
b8d3c3d
@mrodrig6
Merge branch 'MFlowCode:master' into master
b6c2863
@mcarcana
resolving conflicts in m_hyperelastic
9bcf5e2
@mcarcana
returning an accidental deletion from conflict resolution
be859c5
@mrodrig6
Merge branch 'master' into 1d2dhyper
40187df
@mrodrig6
further cleaning to the code
0dca297
@mcarcana
1D btensor algorithm corrected
d9d6f8a
@mcarcana
cleaning 2d hyper
b6cf35d
@mcarcana
addressing warning when building m_hyperelastic
4ee8d32
@mcarcana
reorganizing num_dim ifs to be 3,2,1
2d0d572
@mcarcana
debugging hyperelasticity
929a820
@mcarcana mcarcana requested review from a team and sbryngelson as code owners February 3, 2025 19:53
@mcarcana mcarcana closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbryngelson sbryngelson Awaiting requested review from sbryngelson sbryngelson is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcarcana @mrodrig6 @sawyer-rem @nkoval2003 @sbryngelson @ChrisZYJ