Fixing Clippy warnings and errors

MIERUNE · Aug 7, 2024 · de98fb5 · de98fb5
1 parent 0deaa34
commit de98fb5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/nusamai/src/sink/obj/mod.rs b/nusamai/src/sink/obj/mod.rs
@@ -95,7 +95,7 @@ impl DataSinkProvider for ObjSinkProvider {
     fn create(&self, params: &Parameters) -> Box<dyn DataSink> {
         let output_path = get_parameter_value!(params, "@output", FileSystemPath);
         let transform_options = self.available_transformer();
-        let has_split = get_parameter_value!(params, "split-obj", Boolean).unwrap() as bool;
+        let has_split = get_parameter_value!(params, "split-obj", Boolean).unwrap();
 
         Box::<ObjSink>::new(ObjSink {
             output_path: output_path.as_ref().unwrap().into(),
@@ -429,7 +429,7 @@ impl DataSink for ObjSink {
                 // Write OBJ file
                 let mut file_path = self.output_path.clone();
                 let has_split = self.obj_options.has_split;
-                let file_name = format!("{}", typename.replace(':', "_"));
+                let file_name = typename.replace(':', "_").to_string();
                 file_path.push(format!("{}_OBJ", file_name));
 
                 std::fs::create_dir_all(&file_path)?;

diff --git a/nusamai/src/sink/obj/obj_writer.rs b/nusamai/src/sink/obj/obj_writer.rs
@@ -53,7 +53,7 @@ pub fn write_obj<W: Write>(
         for (i, vertex) in feature_data.iter().enumerate() {
             faces_by_material
                 .entry(vertex.material_id)
-                .or_insert_with(Vec::new)
+                .or_default()
                 .push((i, vertex));
         }