From de98fb59f25a7baa0c9a011a1a9a23f886117f19 Mon Sep 17 00:00:00 2001 From: satoshi komatsu Date: Wed, 7 Aug 2024 18:23:44 +0900 Subject: [PATCH] Fixing Clippy warnings and errors --- nusamai/src/sink/obj/mod.rs | 4 ++-- nusamai/src/sink/obj/obj_writer.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/nusamai/src/sink/obj/mod.rs b/nusamai/src/sink/obj/mod.rs index 6a81d2c4..04d558a6 100644 --- a/nusamai/src/sink/obj/mod.rs +++ b/nusamai/src/sink/obj/mod.rs @@ -95,7 +95,7 @@ impl DataSinkProvider for ObjSinkProvider { fn create(&self, params: &Parameters) -> Box { let output_path = get_parameter_value!(params, "@output", FileSystemPath); let transform_options = self.available_transformer(); - let has_split = get_parameter_value!(params, "split-obj", Boolean).unwrap() as bool; + let has_split = get_parameter_value!(params, "split-obj", Boolean).unwrap(); Box::::new(ObjSink { output_path: output_path.as_ref().unwrap().into(), @@ -429,7 +429,7 @@ impl DataSink for ObjSink { // Write OBJ file let mut file_path = self.output_path.clone(); let has_split = self.obj_options.has_split; - let file_name = format!("{}", typename.replace(':', "_")); + let file_name = typename.replace(':', "_").to_string(); file_path.push(format!("{}_OBJ", file_name)); std::fs::create_dir_all(&file_path)?; diff --git a/nusamai/src/sink/obj/obj_writer.rs b/nusamai/src/sink/obj/obj_writer.rs index 9b5c8a1a..6768d4fa 100644 --- a/nusamai/src/sink/obj/obj_writer.rs +++ b/nusamai/src/sink/obj/obj_writer.rs @@ -53,7 +53,7 @@ pub fn write_obj( for (i, vertex) in feature_data.iter().enumerate() { faces_by_material .entry(vertex.material_id) - .or_insert_with(Vec::new) + .or_default() .push((i, vertex)); }