Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CityGMLのObject表現周りをいくらか整理 #134

Merged
merged 5 commits into from
Dec 28, 2023
Merged

CityGMLのObject表現周りをいくらか整理 #134

merged 5 commits into from
Dec 28, 2023

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Dec 27, 2023 •
edited
Loading

大きな変更点：

  • TopLevelCityObject の名前を CityObject に変更する
    • Transformerで地物ツリーを展開し、子Featureをrootとして後段に送る可能性もあるため
  • Feature (idやジオメトリをもつもの) のほかに Data (idやジオメトリをもたないもの) を追加

その他細かい改善。

Closes: #114

@codecov Codecov
Copy link

codecov bot commented Dec 27, 2023 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Files Patch % Lines
nusamai-citygml/src/values.rs 86.48% 5 Missing ⚠️
nusamai/src/sink/geojson/mod.rs 73.68% 5 Missing ⚠️
app/src-tauri/src/example.rs 0.00% 3 Missing ⚠️
nusamai-citygml/macros/src/derive.rs 93.87% 3 Missing ⚠️
nusamai-citygml/macros/src/lib.rs 0.00% 1 Missing ⚠️
nusamai-citygml/src/object.rs 98.86% 1 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
GUI 0.00% <0.00%> (ø)
Backend 61.29% <75.00%> (+0.30%) ⬆️
Libraries 88.51% <94.50%> (+0.20%) ⬆️

📢 Thoughts on this report? Let us know!

@ciscorn ciscorn force-pushed the feature/revise-citygml-object branch from 16aa5cb to c4a090c Compare December 27, 2023 21:27
@ciscorn ciscorn changed the title CityGMLのObject表現をいくらか整理 CityGMLのObject表現周りをいくらか整理 Dec 27, 2023
@ciscorn ciscorn requested a review from nokonoko1203 December 28, 2023 01:41
@ciscorn ciscorn force-pushed the feature/revise-citygml-object branch 2 times, most recently from 73a821d to fa38470 Compare December 28, 2023 01:52
@ciscorn ciscorn force-pushed the feature/revise-citygml-object branch from fa38470 to f79a15a Compare December 28, 2023 03:09
@ciscorn ciscorn self-assigned this Dec 28, 2023
@ciscorn ciscorn force-pushed the feature/revise-citygml-object branch from af70a73 to f2764e3 Compare December 28, 2023 03:59
@ciscorn ciscorn marked this pull request as ready for review December 28, 2023 04:19
@ciscorn ciscorn added the Design label Dec 28, 2023
@ciscorn ciscorn enabled auto-merge (squash) December 28, 2023 04:28
nokonoko1203
nokonoko1203 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@nokonoko1203 nokonoko1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マクロの部分とかは詳しく見れてませんが、CityOnjectの部分がシンプルでわかりやすくなったのを確認しました！ありがとうございます！
LGTM！

@ciscorn ciscorn disabled auto-merge December 28, 2023 04:46
@ciscorn ciscorn enabled auto-merge (squash) December 28, 2023 04:46
@ciscorn ciscorn merged commit bc431bf into main Dec 28, 2023
5 checks passed
@ciscorn ciscorn deleted the feature/revise-citygml-object branch December 28, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nokonoko1203 nokonoko1203 nokonoko1203 approved these changes

Assignees

@ciscorn ciscorn

Labels
Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FeatureOrData を Feature と Data に分ける
2 participants
@ciscorn @nokonoko1203