抽象型FacilityAttributeの定義 #137
Conversation
Codecov ReportAttention:
Additional details and impacted files
📢 Thoughts on this report? Let us know! |
| #[citygml_data(name = "uro:FishingPortFacilityAttribute")]//スキーマに存在しない | ||
| pub struct FishingPortFacilityAttribute { |
There was a problem hiding this comment.
//スキーマに存在しない
スキーマを見た感じだと、uro:FishingPortCapacity と uro:FishingPortFacility という名前が正しいようですね。
There was a problem hiding this comment.
uro:FishingPortCapacity と uro:FishingPortFacilityは下にあるので、この二つを削除しときますね。
| @@ -1,65 +1,1454 @@ | |||
| use nusamai_citygml::citygml_property; | |||
| use nusamai_citygml::{citygml_property,citygml_data,CityGMLElement,Code,Measure,Date}; | |||
There was a problem hiding this comment.
nits: ここってエディターで自動整形されないですかね... 🤔
VS Code
https://tech.uzabase.com/entry/2022/12/28/094600
JetBrains
https://zenn.dev/hkusu/articles/ce6d289fa6588e#clippy-%E3%81%AE%E9%81%A9%E7%94%A8
| #[citygml(path = b"uro:portFacilityDetailsType")] | ||
| pub port_facility_details_type: Code,//スキーマに存在しない | ||
|
|
||
| #[citygml(path = b"uro:portName")] | ||
| pub port_name: String, | ||
|
|
There was a problem hiding this comment.
内部の処理の都合上、[1..1] のものも Option<T> になっているのがよいです！
いずれ「required」であることを表現できるようにしたいです。
| pub is_designated: Option<bool>, | ||
|
|
||
| #[citygml(path = b"uro:degradationLevel")] | ||
| pub degradation_level: Option<u64>, |
There was a problem hiding this comment.
xs:integer 型は、負数の可能性もあるので i64 がよいです。おそらく facility.rs に登場するものはすべて i64 ではないかと。
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| #[citygml(path = b"uro:lefEndDistance")] | ||
| pub lef_end_distance: Option<Measure>, |
There was a problem hiding this comment.
memo: スキーマを信じるしかないですが、スキーマにこういうタイポありますよね。。。
| #[citygml(path = b"uro:FishingPortFacility")] | ||
| FishingPortFacilityAttribute(FishingPortFacility), |
| #[citygml(path = b"uro:RiverFacilityIdAttribute")] | ||
| RiverFacilityIdAttribute(RiverFacilityIdAttribute), |
There was a problem hiding this comment.
こちら FacilityIdAttribute の下位型なのでここには登場しないハズと思います。
relate #117
uro:PortAttribute以外を実装TODO:テスト