Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citygml: 名前空間周りの修正、テスト追加など #141

Merged
merged 8 commits into from
Jan 4, 2024
Merged

citygml: 名前空間周りの修正、テスト追加など #141

merged 8 commits into from
Jan 4, 2024
+116 −11

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Dec 31, 2023 •
edited
Loading

名前空間の扱い周り：簡単なテストの追加と、ちょっとした修正

@ciscorn ciscorn requested a review from a team December 31, 2023 02:59
@ciscorn ciscorn self-assigned this Dec 31, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 31, 2023 •
edited
Loading

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Files Patch % Lines
nusamai-plateau/src/models/iur/uro/ifc.rs 5.88% 32 Missing ⚠️
...amai-plateau/src/models/iur/uro/utility_network.rs 0.00% 15 Missing ⚠️
nusamai-citygml/src/parser.rs 58.62% 12 Missing ⚠️
nusamai-plateau/src/models/iur/uro/indoor.rs 0.00% 9 Missing ⚠️
...samai-plateau/src/models/iur/uro/transportation.rs 0.00% 9 Missing ⚠️
nusamai-plateau/src/models/iur/uro/building.rs 41.66% 7 Missing ⚠️
nusamai-plateau/src/models/iur/uro/waterbody.rs 0.00% 6 Missing ⚠️
nusamai-citygml/macros/src/derive.rs 92.53% 5 Missing ⚠️
nusamai-plateau/src/models/waterbody.rs 0.00% 4 Missing ⚠️
nusamai-plateau/src/models/building.rs 72.72% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
Components Coverage Δ
GUI ∅ <ø> (∅)
Backend 61.82% <ø> (ø)
Libraries 84.83% <67.96%> (-3.61%) ⬇️

📢 Thoughts on this report? Let us know!

@ciscorn ciscorn changed the base branch from main to testdrive-modelgen December 31, 2023 03:07
@ciscorn ciscorn changed the title citygml: xmlnsのテスト追加、足りない名前空間の追加 citygml(xmlns): テスト追加、足りない名前空間の追加 Dec 31, 2023
@ciscorn ciscorn force-pushed the feature/improve-xml-namespaces branch from f56ea9d to dbb9f0d Compare December 31, 2023 03:24
@ciscorn ciscorn force-pushed the testdrive-modelgen branch from a0bf8bc to 2863227 Compare January 3, 2024 14:28
@ciscorn ciscorn force-pushed the feature/improve-xml-namespaces branch from dbb9f0d to 1eaa5f8 Compare January 3, 2024 14:44
@ciscorn ciscorn force-pushed the testdrive-modelgen branch from 2863227 to f9f2408 Compare January 3, 2024 15:13
@ciscorn ciscorn force-pushed the feature/improve-xml-namespaces branch from 1eaa5f8 to 3011fb4 Compare January 3, 2024 15:17
@ciscorn ciscorn force-pushed the feature/improve-xml-namespaces branch from 3011fb4 to 3e7de7e Compare January 3, 2024 16:03
@ciscorn ciscorn force-pushed the testdrive-modelgen branch from f9f2408 to bc8fc3e Compare January 3, 2024 16:05
@ciscorn ciscorn changed the title citygml(xmlns): テスト追加、足りない名前空間の追加 citygml: 名前空間周りの修正、テスト追加など Jan 3, 2024
sorami
sorami approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@sorami sorami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from testdrive-modelgen to main January 4, 2024 05:53
@ciscorn ciscorn enabled auto-merge (squash) January 4, 2024 05:56
@ciscorn ciscorn merged commit 648f112 into main Jan 4, 2024
2 checks passed
@ciscorn ciscorn deleted the feature/improve-xml-namespaces branch January 4, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorami sorami sorami approved these changes

Assignees

@ciscorn ciscorn

Labels
CityGML Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciscorn @sorami