Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVT Sink の初期実装 #163

Merged
merged 20 commits into from
Jan 12, 2024
Merged

MVT Sink の初期実装 #163

merged 20 commits into from
Jan 12, 2024

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Jan 9, 2024

ひとまず以下までを「ぐちゃぐちゃのコード」でやっています。いったんマージしたいです。

  • ポリゴンをタイル境界 (Web Mercator) で切る
  • 同一地物のMultiPolygonをタイル座標ごとにまとめる
  • MVTを出力する
  • MVTへの属性(タグ)付けはやっていない

Cargo のビルドスクリプト (bulid.rs) によって .proto から自動生成される vector_tile.rs は リポジトリに含めるようにした。(各々の環境に protoc がなくてもビルドできるようにするため)


MVT生成の動作確認をしたい方は以下のようにどうぞ:

cargo run --release -- ~/Desktop/PLATEAU/15100_niigata-shi_2022_citygml_1_op/udx/bldg/*.gml --sink tiling2d --output hoge

@ciscorn ciscorn added the Output Fomat Output format drivers label Jan 9, 2024
@ciscorn ciscorn self-assigned this Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Files Patch % Lines
nusamai/src/sink/mvt/mod.rs 85.21% 55 Missing ⚠️
nusamai-mvt/src/vector_tile.rs 0.00% 26 Missing ⚠️
nusamai-mvt/src/geometry.rs 91.11% 4 Missing ⚠️
nusamai/src/main.rs 0.00% 4 Missing ⚠️
app/src-tauri/src/main.rs 0.00% 1 Missing ⚠️
nusamai-citygml/src/values.rs 75.00% 1 Missing ⚠️
nusamai-mvt/src/tileid/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
GUI 0.00% <0.00%> (ø)
Backend 77.75% <84.39%> (+2.01%) ⬆️
Libraries 86.04% <73.55%> (-0.32%) ⬇️

📢 Thoughts on this report? Let us know!

@ciscorn ciscorn marked this pull request as draft January 11, 2024 03:11
@ciscorn ciscorn changed the title WIP: 2Dタイリングのデモを改善する 2Dタイリングのデモを改善する Jan 11, 2024
@ciscorn ciscorn requested a review from a team January 11, 2024 07:55
@ciscorn ciscorn marked this pull request as ready for review January 11, 2024 07:56
@ciscorn ciscorn marked this pull request as draft January 11, 2024 07:57
@ciscorn ciscorn marked this pull request as ready for review January 11, 2024 10:40
@ciscorn ciscorn changed the title 2Dタイリングのデモを改善する MVT Sink の初期実装 Jan 11, 2024
Copy link
Member

@sorami sorami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ざっとみました、LGTM!

@ciscorn
Copy link
Member Author

ciscorn commented Jan 12, 2024

ちょっと処理の無駄を省いてからマージします

@ciscorn ciscorn enabled auto-merge (squash) January 12, 2024 04:31
@ciscorn ciscorn merged commit 2779adf into main Jan 12, 2024
3 checks passed
@ciscorn ciscorn deleted the improve-tiling2d-demo branch January 12, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output Fomat Output format drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants