#169 修正用ブランチ #197
Merged
#169 修正用ブランチ #197
+901
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
#160 - CityObjectを受け取り、以下のようなことを行う一連の処理群を仮実装しました - CityObject.root（Feature）から子要素のFeatureを抽出 - Dataを別レイヤー化 - 子要素の別地物化 - 属性情報の個別変換- - sinkなどから利用することを想定しています - 特に問題ないということであればそれはそれで良いのですが、あくまで仮実装のイメージで、今後ブラッシュアップしていきます - 挙動 - 設定方法 - 出力されるCityObject - 出力ドライバーでの扱い - プログラムの構造 - 以下のようなコマンドで動作します - リポジトリのルートに「マッピングルール」を想定した、以下のようなJSONファイルを置いてください - 実行後、リポジトリのルートに「output_object.json」が出力されます - これをsink内で利用して出力していく想定です [mappings.json](https://github.com/MIERUNE/nusamai/files/13983445/mappings.json) ```bash cargo run --package nusamai /Users/satoru/Downloads/plateau/22203_numazu-shi_2021_citygml_4_op/udx/bldg/52385618_bldg_6697_op.gml --sink geojson --output ~/Downloads/output/output.geojson ``` --------- Co-authored-by: Taku Fukada <naninunenor@gmail.com>
Codecov ReportAttention: Additional details and impacted files
📢 Thoughts on this report? Let us know! |
ciscorn
commented
Jan 23, 2024
ciscorn
commented
Jan 23, 2024
| } | ||
| } | ||
|
|
||
| fn flatten( |
There was a problem hiding this comment.
1つ目の子までしか見ていなかったので、再帰的に展開するように変更。
ciscorn
commented
Jan 23, 2024
| } | ||
| } | ||
|
|
||
| impl Transform for SerialTransform { |
There was a problem hiding this comment.
Transformを直列にしたものもTransformである、ようにしておく。
ciscorn
commented
Jan 23, 2024
ciscorn
commented
Jan 23, 2024
| let mut entities = serial_transform.transform(entity); | ||
|
|
||
| // 属性の変換などを行うEditor | ||
| let mut traversal = SerialEditor { |
nokonoko1203
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#169 を、既存のコードベースに影響を与えない、実験用のSinkとしてマージできるようにする。