nusamai-shapefile: クレート作成, MultiPointの変換 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files
📢 Thoughts on this report? Let us know! |
sorami
changed the title
ciscorn
reviewed
Jan 26, 2024
Comment on lines
+4
to
+9
| // Attribute fields for the features | ||
| // FieldName byte representation cannot exceed 11 bytes | ||
| let table_builder = dbase::TableWriterBuilder::new() | ||
| .add_character_field("name".try_into().unwrap(), 50) | ||
| .add_float_field("lon".try_into().unwrap(), 50, 10) | ||
| .add_float_field("lat".try_into().unwrap(), 50, 10); |
There was a problem hiding this comment.
Shapefile もやはりはじめにテーブルを宣言しないといけない形式ですね。
ありがとうございます！ |
sorami
added a commit
that referenced
this pull request
Jan 26, 2024
#203 （MultiPoint）と同じ形で、nusamai-geometryのMultiLineString, MultiPolygonを、Shapefileの形式へ変換する。 ## 参考 ### ポリゴンは、複数のOuterリングを持つことができる https://github.com/tmontaigu/shapefile-rs/blob/cd52bcfde8ce24aeaffec0968f155119e02c5a66/src/record/polygon.rs#L198C1-L204C59 ``` /// # Notes /// - A Polygon ring is a connected sequence of 4 or more points /// **(this is not checked)** /// - Polygon's rings MUST be closed (the first and last points MUST be the same) (p 13/34) /// **(this is done by the constructors if you do not do it yourself)** /// - The order of rings is not significant (p 13/34) /// - A polygon may have multiple [`Outer`] rings (p12/34) ``` ### リングのオーダー https://github.com/tmontaigu/shapefile-rs/blob/cd52bcfde8ce24aeaffec0968f155119e02c5a66/src/record/polygon.rs#L26-L37 ``` /// In shapefile, the point ordering is what is used to know if /// a ring is an outer or inner one: /// - **Outer** ring => points in clockwise order /// - **Inner** ring => points in counter-clockwise order /// /// # Note /// /// Rings you get access from a [`GenericPolygon`] will always have its points ordered /// according to its type (outer, inner). /// /// But `PolygonRing`s you create won't be reordered until you move them into /// a [`GenericPolygon`]. ``` https://github.com/tmontaigu/shapefile-rs/blob/cd52bcfde8ce24aeaffec0968f155119e02c5a66/src/record/mod.rs#L118-L134 ``` /// Given the points, check if they represent an outer ring of a polygon /// /// As per ESRI's Shapefile 1998 whitepaper: /// ` /// The order of vertices or orientation for a ring indicates which side of the ring /// is the interior of the polygon. /// The neighborhood to the right of an observer walking along /// the ring in vertex order is the neighborhood inside the polygon. /// Vertices of rings defining holes in polygons are in a counterclockwise direction. /// Vertices for a single, ringed polygon are, therefore, always in clockwise order. /// ` /// /// Inner Rings defines holes -> points are in counterclockwise order /// Outer Rings's points are un clockwise order /// /// https://stackoverflow.com/questions/1165647/how-to-determine-if-a-list-of-polygon-points-are-in-clockwise-order/1180256#1180256 pub(crate) fn ring_type_from_points_ordering<PointType: HasXY>(points: &[PointType]) -> RingType { ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
nusamai-shapefileクレートの作成nusamai_geometry::MultiPointから Shapefile形式への変換examples/{read,write}.rs- ファイル読み書きの参考例（tmp - 最終的に削除する）まず例として小さく、MultiPointの部分のみを作ったプルリクです。方向性に問題ないかご確認いただけますでしょうか！
外部クレート shapefile を用いて実装しています。
リファクタしてもらった
nusamai-geojsonの形（#154）をもとにしています（ので、それをやった @ciscorn さんを明示的にレビューアーへ入れてみました）。3D地物（
nusamai_geometry::MultiPoint::<3>,shapefile::MultiPointZ）のみで、2Dは考慮していません。その後の進め方
related #198
この方向性で問題なければ、それを踏まえて、以下の順に進めていく予定です: