-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update doc #696
update doc #696
Conversation
Walkthroughこのプルリクエストは、ドキュメント生成スクリプトに2つの小さな変更を加えています。1つ目は Changes
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/src/make_mapping_rule_doc.sh (1)
3-3
: シェルスクリプトの堅牢性を改善する機会ファイル名から不要なドットを削除したのは適切な変更です。しかし、以下の改善を推奨します:
+#!/bin/bash +set -eu + for FILE_FORMART in shapefile gpkg geojson czml kml mvt 3dtiles do cargo run -p nusamai -- 64413325_bldg_6697_op.gml --schema schema_${FILE_FORMART}.json --sink $FILE_FORMART --output out.dummy + if [ $? -ne 0 ]; then + echo "Error processing ${FILE_FORMART}" + exit 1 + fi done変更点の説明:
- シェバン行の追加でスクリプトの実行環境を明示
set -eu
でエラー時の即時終了とunset変数の使用防止- エラーハンドリングの追加でトラブルシューティングを容易に
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
docs/src/schema_3dtiles.json
is excluded by!**/*.json
docs/src/schema_czml.json
is excluded by!**/*.json
docs/src/schema_geojson.json
is excluded by!**/*.json
docs/src/schema_gpkg.json
is excluded by!**/*.json
docs/src/schema_kml.json
is excluded by!**/*.json
docs/src/schema_mvt.json
is excluded by!**/*.json
docs/src/schema_shapefile.json
is excluded by!**/*.json
📒 Files selected for processing (2)
docs/src/make_mapping_rule_doc.sh
(1 hunks)docs/src/schema_to_doc.py
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: test
- GitHub Check: build
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
docs/src/schema_to_doc.py (2)
33-33
: ORDER_MAPに新しいエントリを追加
xAL
のエントリ追加は適切で、既存の順序付けパターンと一致しています。
87-87
: 出力フォーマットの一貫性を改善スペース調整により、出力テーブルのフォーマットがより一貫性のあるものになりました。
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files
📢 Thoughts on this report? Let us know! |
Close #0
What I did(変更内容)
ORDER_MAP
にxAL
のキーを追加Notes(連絡事項)
docs/src/make_mapping_rule_doc.sh
のinputファイル名の先頭に.
が入っていいて、スクリプトが動かなかったので削除しました(何か意図があれば戻します)