地下街モデルのthematicSrcDescのスキーマを追加

[satoshi7190]

Close #0

What I did（変更内容）

• 新宿区の地下街モデル変換時にスキーマが不足していたため対応

13104_shinjuku-ku_city_2023_citygml_1_op/udx/ubld/53394536_ubld_6697.gml

Notes（連絡事項）

None / なし

[coderabbitai]

Walkthrough

今回の変更は、nusamai-plateau/src/models/iur/uro/common.rs 内の BuildingDataQualityAttribute 構造体に新しいフィールド thematic_src_desc（型は Vec<Code>）を追加するものです。フィールドには #[citygml(path = b"uro:thematicSrcDesc")] アトリビュートが付与されています。他の既存のフィールドや構造体には変更はありません。

Changes

ファイル	変更内容
nusamai-plateau/src/.../common.rs	BuildingDataQualityAttribute 構造体に pub thematic_src_desc: Vec<Code> フィールドを追加（アトリビュート: #[citygml(path = b"uro:thematicSrcDesc")]）

Possibly related PRs

• 地下街モデルのuro:BuildingDataQualityAttributeの対応 #694: BuildingDataQualityAttribute 構造体の変更に関連し、同構造体の定義に対する修正があったPR。

Suggested labels

enhancement

Suggested reviewers

• nokonoko1203

Poem

春風に乗り
ぴょんぴょん走る私
新たなフィールドが舞い降り
建物の秘密をそっと包む
小さなウサギが幸せを届ける 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae13509 and d5fdc88.

📒 Files selected for processing (1)

• nusamai-plateau/src/models/iur/uro/common.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build
• GitHub Check: test

🔇 Additional comments (1)

nusamai-plateau/src/models/iur/uro/common.rs (1)

102-104:

✅ Verification successful

新しいフィールドの追加が適切に実装されています！

thematic_src_descフィールドの実装は以下の点で適切です：

• 他のソース記述フィールドと一貫した型（Vec<Code>）を使用
• CityGMLのパス属性が正しい命名規則に従っている
• 構造体の設計方針と一致する可視性（pub）を持つ

CityGMLスキーマとの互換性を確認するため、以下のスクリプトを実行してください：

---

🏁 Script executed:

#!/bin/bash
# CityGMLスキーマ内でthematicSrcDescの定義を確認

# uro:thematicSrcDescの使用例を検索
rg -i "thematicSrcDesc" . --type xml

Length of output: 872

---

新しいフィールドの追加は問題なく実装されています

• thematic_src_desc フィールドは Vec<Code> 型で、他のソース記述フィールドと一貫性があります。
• CityGML のパス属性 uro:thematicSrcDesc も正しい命名規則に従っています。
• テストデータ内（例: tests/data/kawasaki-shi/codelists/BuildingDataQualityAttribute_thematicSrcDesc.xml）でも同様の定義が確認され、CityGML スキーマとの互換性も問題ありません。

このままマージして大丈夫です。

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

Components	Coverage Δ
GUI	∅ <ø> (∅)
Backend	74.64% <ø> (ø)
Libraries	85.87% <ø> (ø)

📢 Thoughts on this report? Let us know!

[nokonoko1203]

@satoshi7190 lgtm!
助かりました！