Update dependencies #708
Merged
Update dependencies #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. """ Walkthrough今回の変更は、 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
nusamai-citygml/Cargo.tomlis excluded by!**/*.tomlnusamai-gpkg/Cargo.tomlis excluded by!**/*.tomlnusamai-projection/Cargo.tomlis excluded by!**/*.tomlnusamai/Cargo.tomlis excluded by!**/*.toml
📒 Files selected for processing (1)
nusamai/tests/pipeline.rs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: test
- GitHub Check: build
🔇 Additional comments (1)
nusamai/tests/pipeline.rs (1)
43-43: ローカルな乱数生成器の導入についてスレッドセーフティとテストの再現性の観点から、グローバルな乱数生成器の代わりにローカルなインスタンスを使用する方針は適切です。
| for _i in 0..100 { | ||
| feedback.ensure_not_canceled()?; | ||
| std::thread::sleep(std::time::Duration::from_millis( | ||
| (5.0 + random::<f32>() * 10.0) as u64, | ||
| (5.0 + rng.random::<f32>() * 10.0) as u64, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
乱数生成の一貫性について
DummySourceでの変更は適切ですが、DummySinkの実装でも同様の変更が必要です。コードベース全体で一貫した乱数生成アプローチを採用することを推奨します。
以下の変更を提案します：
impl DataSink for DummySink {
fn run(&mut self, upstream: Receiver, feedback: &Feedback, _schema: &Schema) -> Result<()> {
+ let mut rng = rand::rng();
for parcel in upstream {
feedback.ensure_not_canceled()?;
std::thread::sleep(std::time::Duration::from_millis(
- (5.0 + random::<f32>() * 20.0) as u64,
+ (5.0 + rng.random::<f32>() * 20.0) as u64,
));Also applies to: 111-113
ciscorn
force-pushed
the
update-deps-20250219
branch
2 times, most recently
from
3e028f0 to
01443f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files
📢 Thoughts on this report? Let us know! |
ciscorn
force-pushed
the
update-deps-20250219
branch
from
01443f9 to
7ba1998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.