Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix missing boolean types in full usage #2693

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Lestropie
Copy link
Member

Noticed while working on #2678 an assertion failure for which the fix is applicable to master. Can see the difference for example for mrconvert -bvalue_scaling option, which currently does not report a type in __print_full_usage__.

Raises a secondary question. Just as the RST documentation is generated and stored within the repository and CI then re-generates and cross-checks against that content, there is an argument to be made for the full interface definitions generated by __print_full_usage__ to be stored within the repository also (as has been argued for the Pydra interfaces in #2665).

@Lestropie Lestropie requested a review from a team August 11, 2023 02:30
@Lestropie Lestropie self-assigned this Aug 11, 2023
@Lestropie Lestropie added this to the 3.0.5 updates milestone Sep 16, 2024
@Lestropie Lestropie added this pull request to the merge queue Nov 20, 2024
Merged via the queue into master with commit 58c1e6b Nov 20, 2024
@Lestropie Lestropie deleted the bool_args_documentation branch November 20, 2024 10:39
@Lestropie Lestropie mentioned this pull request Jan 14, 2025
31 tasks
Lestropie added a commit that referenced this pull request Jan 15, 2025
Resolution of content merged to dev initially omitted from #3061.
- #2693 (completely omitted)
- #3005 (partial propagation / independent address of some common issues on both branches)
- #3001 (completely omitted)
- #2908 (completely omitted)
- #2955 (completely omitted)
- #2600 (completely omitted)
- #2962 (completely omitted)
- #2935 (completely omitted)
- #2923 (completely omitted)
- #2910 (completely omitted)
- #2638 (completely omitted)
- #2698 (completely omitted)
- #2721 (completely omitted)
- #2794 (completely omitted)
- #2768 (completely omitted; required modification to conform to other dev changes)
- #2713 (residual compilation errors following adf8fdd, including resolution against changes in #2437 on dev.
Lestropie added a commit that referenced this pull request Jan 15, 2025
Resolution of content merged to dev initially omitted from #3061.
- #2693 (completely omitted)
- #3005 (partial propagation / independent address of some common issues on both branches)
- #3001 (completely omitted)
- #2908 (completely omitted)
- #2955 (completely omitted)
- #2600 (completely omitted)
- #2962 (completely omitted)
- #2935 (completely omitted)
- #2923 (completely omitted)
- #2910 (completely omitted)
- #2638 (completely omitted)
- #2698 (completely omitted)
- #2721 (completely omitted)
- #2794 (completely omitted)
- #2768 (completely omitted; required modification to conform to other dev changes)
- #2713 (residual compilation errors following adf8fdd, including resolution against changes in #2437 on dev.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants