-
Notifications
You must be signed in to change notification settings - Fork 18
Multiweight implementation #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jackaraz
wants to merge
109
commits into
substructure
Choose a base branch
from
multiweight
base: substructure
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
109 commits
Select commit
Hold shift + click to select a range
22ac078
mitigating weight to multiweight
jackaraz bfab5b2
multiweight adaptation
jackaraz 5e405c6
refactor
jackaraz 2c71717
add basic positive/negative weight strucutre
jackaraz c0648c2
update weight base
jackaraz 8b32077
update readers
jackaraz b7fad97
update region selection manager
jackaraz 66c0680
update cutflow
jackaraz f7d5e8b
update histograms
jackaraz f9d2e25
update LHE writer
jackaraz a3cbd62
bug fixes
jackaraz 13db690
addd accesor for weight names
jackaraz d56d201
add preparation for execution
jackaraz a92eabd
update `main.cpp` writers
jackaraz ef9177c
bug fix in initialisation
jackaraz fd84f09
bugfix in histogramming
jackaraz c12766d
change basics to histo structures
jackaraz 32fc384
update basics.h
jackaraz 8c3553b
remove `weight_definition_`
jackaraz e95b46a
remove `weight_definition_`
jackaraz 4aa439d
update exception
jackaraz 9ad2634
update exception text
jackaraz 55da958
update docstring
jackaraz e6e19fc
update exception message
jackaraz 12b3f26
update docstring
jackaraz c0c9139
update execution order
jackaraz ac3a7a0
update docstring
jackaraz 214b672
update exception handler
jackaraz f20edd7
update docstring
jackaraz 9234845
remove unnecessary decleration
jackaraz 3779599
remove comment
jackaraz 9174303
uncomment resize
jackaraz 3c9e610
remove weight definition
jackaraz fd692be
add weight shortcut
jackaraz bcc6eb3
clean the code
jackaraz ac59bd2
update getweight
jackaraz 99796ed
bugfix
jackaraz 250d98a
update histogram structure
jackaraz 80d5b01
update histogramming module
jackaraz c3ff020
update changelog
jackaraz cc192ae
write weight names
jackaraz 7ad2f01
add weight names to the summary
jackaraz 4f1230c
cleaning
jackaraz ed02895
update reference to weight names
jackaraz ccc3549
initialise weight configuration
jackaraz 7a6d1c7
integrate weight config
jackaraz fc7862e
add properties
jackaraz 5406657
add weight reader
jackaraz 981c36e
revert some of the structure
jackaraz 7c3f9c4
add processor
jackaraz 6619661
adaptation
jackaraz f1d9126
add lhapdf list
jackaraz e2bd263
create dataset for weight collection
jackaraz 82d7a02
additional features
jackaraz 0ea5874
bugfix
jackaraz b412479
add dynamic scale choice and npoint scale var
jackaraz 59911c0
add an extra array
jackaraz a6232c9
extend data handling
jackaraz 3eef3af
simplify the code
jackaraz 946f726
incomplete multiweight treatment
jackaraz 746240d
extended reporting
jackaraz 0083d63
add debug sections
jackaraz f329ab8
bugfix
jackaraz 9205e66
bugfix
jackaraz c4738af
temporary fix allowing to at least install delphes. To be further fixed
BFuks f1c3927
Updating uncertainty calculations
BFuks 6f39dad
Merge branch 'substructure' into multiweight
jackaraz 2a90913
return weight collection object for queries
jackaraz b23ebd8
efficiency updates
jackaraz dc8f0cd
root plots
BFuks 01ef527
small bug fix in root file generation
BFuks 0572f22
bugfix for histogram initialisation
jackaraz 23f5525
starting to fix bugs in cutflows + generalisation
BFuks e026f3d
restore
jackaraz e5e04d0
add multiweight handler
jackaraz 93f1993
minor fixes
jackaraz 503b28e
add separate multiweight reader
jackaraz 98c6d1c
adapt
jackaraz 014545a
Merge branch 'substructure' into multiweight
jackaraz f6360ff
fix for scale vars
jackaraz 9ef2cc0
overlap removal
jackaraz ec50d43
convert print to debug
jackaraz 51c62ae
add scale vars
jackaraz bed7c97
extend the usage
jackaraz b4391c0
add combination between pdf and scale unc
jackaraz a452b1f
only write total unc
jackaraz 1951263
compactify the loop
jackaraz eef8496
silence the warnings
jackaraz bfb3334
implement eigvectors method
jackaraz dbb376e
bugfix
jackaraz 255643e
update version
jackaraz 55e6e44
multiple fixes
jackaraz b603745
add lhapdf info
jackaraz 534099e
improvement
jackaraz fbb7185
replace lhapdf info
jackaraz bac598e
sort pdfset, improve eff
jackaraz 777622a
add protection against mistakes in files
jackaraz 9a79370
update comment
jackaraz 3de9da1
Small extra fix for MadSTR-generated events
BFuks 354307b
Small extra fix for MadSTR-generated events (part 2)
BFuks 5a77e46
typo fix
jackaraz e5e983d
increase protection
jackaraz 9477304
fix for multiweighted-events without PDF variation
BFuks 10df24d
Fixing resubmit bug + invisible state bug (thanks to L. Munoz)
BFuks 923554c
Adding multiweight support in the LHE writer
BFuks cef926e
LHE files and multiweight support fixed/added
BFuks a7af8c0
Updating the plotflow and the layout
BFuks dbd1944
fixing the importlib issue in bin/ma5
BFuks cfb879e
Adding scale information to the dataset printout
BFuks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe rewrite as:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. You can use "make a suggestion" option when checking, that automatically creates a comit for the portion of the code that you want to change. Will be more efficient.