Open more-info dialog always big

[Mariusthvdb]

pasted from NemesisRE/kiosk-mode#338 (comment)

@elchininet see https://community.home-assistant.io/t/open-more-info-dialog-always-big/829411/5
not sure if you saw this, and what you might think.
would this be a useful feature for either of the mentioned plugins, be it Kiosk mode or custom-more-info? and if yes, next would be: is it feasible?
cheers, Marius

@Mariusthvdb,

No for kiosk-mode because it falls on the side of styling things and not to block or obscure things. But for a plugin called custom-more-info it fits perfectly. It should be feasible, just copying that code there should be enough.

[Mariusthvdb]

not sure what you mean by 'that code' but maybe you refer to the suggestion Ildar did in the community?

customElements.whenDefined('ha-more-info-dialog').then(UIElement => {
  const { css } = UIElement.prototype;
  const newStyle = css`
    @media (min-width: 600px) and (min-height: 501px) {
      ha-dialog {
        --mdc-dialog-min-width: 90vw !important;
        --mdc-dialog-max-width: 90vw !important;
      }
    }`;
  UIElement.elementStyles.push(newStyle);
});

?

Tbh, I am not are what that does exactly except for checking the screen and setting min-width to 90vw..

I would think we would use a conditional option like the other settings, and maybe even allow to do that with a boolean in the UI (much like Kiosk mode is handling that)?

[elchininet]

not sure what you mean by 'that code' but maybe you refer to the suggestion Ildar did in the community?

I am referring just to the variables part because this plugin already queries the more-info dialogs and already adds styles to them.

--mdc-dialog-min-width: 90vw !important;
--mdc-dialog-max-width: 90vw !important;

But now looking at the code, I am seeing that the more info dialogs have a large property and even an _enlarge method (which is the one used when one clicks on the title), so no need for those CSS variables, it is possible to use the default functionality.

I would think we would use a conditional option like the other settings, and maybe even allow to do that with a boolean in the UI (much like Kiosk mode is handling that)?

The configuration part can be done in multiple ways, a boolean as you are suggesting seems like a reasonable one.

[Mariusthvdb]

ok thanks, Ill leave this open in that case, hoping you can have a look at it, or if already possible, guide me how to do so.

my personal preference would be to not write card_mod stuff for this, but have some native option in the plugin itself

[elchininet]

ok thanks, Ill leave this open in that case, hoping you can have a look at it, or if already possible, guide me how to do so.

Sure, I'll take a look when I get some time. It should not be hard to implement.

my personal preference would be to not write card_mod stuff for this, but have some native option in the plugin itself.

The more info modals already have that functionality, no need to use card-mod to change those properties.

[elchininet]

@Mariusthvdb,
Test it to check that it works properly: #23