Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turnigy fabrikator configs #1010

Merged

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Jan 27, 2024

Requirements

A Turnigy fabrikator

Description

#649 (comment) requested that the configs in
https://github.com/PsychoOW/Turnigy-Fabrikator-Marlin-Firmware-Configuration be added

Benefits

Turnigy fabrikator has example configs

Related Issues

#649 (comment)

Notes

I just added the preexisting configs, I do not have this machine and cannot test these beyond compiling.

@ellensp
Copy link
Contributor Author

ellensp commented Jan 27, 2024

@PsychoOW Please test these configs on Marlin bugfix 2.1.x

To test this you need to comment out the these two lines in Configuration.h

#error "Don't build with import-2.1.x configurations!"
#error "Use the 'bugfix...' or 'release...' configurations matching your Marlin version."

@PsychoOW
Copy link

Hello, i just saw it. Thank you so much for helping!! :) i am a bit overwhelmed right now how fast that went :O thank you so much!
i will test it tomorow when i figured out githubs overlay lol all of that is very new for me.
i saw you removed a line with the fabrikator display i think. which is the standard display. but maybe i saw something wrong. I will definitely test it Asap! :) now i have unfortunatly to go to sleep, because i have to wake up very early.
I will get back to you asap :)

@PsychoOW
Copy link

@PsychoOW Please test these configs on Marlin bugfix 2.1.x

To test this you need to comment out the these two lines in Configuration.h

#error "Don't build with import-2.1.x configurations!"
#error "Use the 'bugfix...' or 'release...' configurations matching your Marlin version."

Hello, i just saw it. Thank you so much for helping!! :) i am a bit overwhelmed right now how fast that went :O thank you so much!
i will test it tomorow when i figured out githubs overlay lol all of that is very new for me.
i saw you removed a line with the fabrikator display i think. which is the standard display. but maybe i saw something wrong. I will definitely test it Asap! :) now i have unfortunatly to go to sleep, because i have to wake up very early.
I will get back to you asap :)

@PsychoOW
Copy link

@PsychoOW Please test these configs on Marlin bugfix 2.1.x

To test this you need to comment out the these two lines in Configuration.h

#error "Don't build with import-2.1.x configurations!"
#error "Use the 'bugfix...' or 'release...' configurations matching your Marlin version."

i cant upload it to printer unfortunatly. tried arduino ide and vs studio. compiling/verify work but upload itself not. i // the things you said.

@ellensp
Copy link
Contributor Author

ellensp commented Jan 27, 2024

uploading has nothing to do with config files...
make sure your reboot before trying to upload, to make sure you have no other programs locking the serial port open (cura, pronterface etc)

@PsychoOW
Copy link

uploading has nothing to do with config files... make sure your reboot before trying to upload, to make sure you have no other programs locking the serial port open (cura, pronterface etc)

Sorry with upload i meant flashing the device :)
anyways, you were right open cura was the problem. i have successfully installed bugfix firmware and can confirm it work. i also print level bed cubes and it works fine. homing worked perfectly too with the sensors.

Amazing! all the hard work turned out perfect :) thank you so much for helping the last miles in order to add it to marlin firmware.

also i find it cool that you added the original Author :)
i had to configure it back to stock Fabricator to make the printer print again. (it refused with the one from the original author due to missing aftermarket custom sensors(BLTouch)) if that matters. i am just happy to helped adding support for that device :D

you are awesome !!! thank you so much!

so far it works fine, if i notice anything i will let you know :)

Copy link

@PsychoOW PsychoOW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration works fine! Thanks alot!

The only thing I noticed was that Crashingdutchman is listed as author. But his settings were custom (added sensors etc.) and I had to configurate it back to "vanilla version" in order to make it useable for my printer. So technically I made the changes and spend a lot time for it :-)
Otherwise it works perfectly and I am very happy to see it.

I am also going to be improving that configuration to make the best out of it without requirement for now Hardware (example mesh bed leveling). So everyone who has that printer will have all awesome functions that does not requires New Hardware and should work on everyone Single vanilla HK Printer.

Copy link

@PsychoOW PsychoOW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, please check my other review

Copy link

@PsychoOW PsychoOW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these configs work fine with bugfix version and the 2 lines commented out which ellen Peter told me to do

@thinkyhead thinkyhead merged commit 330527e into MarlinFirmware:import-2.1.x Mar 14, 2024
1 check passed
@ellensp ellensp deleted the add-Turnigy-Fabrikator branch March 14, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants