Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 BIQU BX updates #1011

Merged

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Jan 28, 2024

Description

  • TOUCH_SCREEN_CALIBRATION is silently undefined in Condtionals_LCD.h, so disable the option to prevent confusion.

    As a test, I disabled the undefines and touch screen calibration / M995 doesn't work on the BIQU BX screen, which is probably why it was silently undefined in the first place.

  • Add a note in the README about homing with a probe for users who are migrating from looxonline's fork and have removed their Z endstop.

  • Use FAN_SOFT_PWM

  • Extruder has a 1.8° motor, so use CHOPPER_DEFAULT_24V for CHOPPER_TIMING_E to prevent CHOPPER_09STEP_24V from being inherited.

Benefits

  • Clearer config, though the silent undefines would probably be better as a sanity check upstream so it's clear what is & isn't enabled in a config.
  • FAN_SOFT_PWM commit allows the part cooling fan to work all the way to 1% speed.
  • CHOPPER_TIMING_E change didn't really affect anything, but it's "more correct".

@thisiskeithb thisiskeithb changed the title Disable TOUCH_SCREEN_CALIBRATION on BIQU BX Disable TOUCH_SCREEN_CALIBRATION on BIQU BX, update README Feb 23, 2024
@thisiskeithb thisiskeithb changed the title Disable TOUCH_SCREEN_CALIBRATION on BIQU BX, update README 🔧 Disable TOUCH_SCREEN_CALIBRATION on BIQU BX, update README Feb 24, 2024
@thisiskeithb thisiskeithb changed the title 🔧 Disable TOUCH_SCREEN_CALIBRATION on BIQU BX, update README 🔧 BIQU BX updates Feb 29, 2024
TOUCH_SCREEN_CALIBRATION is silently undef'd, so disable the option to prevent confusion.
Users migrating from looxonline's fork have likely removed their Z endstop and home with the stock probe.
Extruder is a 1.8° motor
@thinkyhead thinkyhead merged commit a45c966 into MarlinFirmware:import-2.1.x Mar 14, 2024
1 check passed
@thisiskeithb thisiskeithb deleted the pr/update_biqu_bx branch March 14, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants