Skip to content

Commit 09e8781

Browse files
committed
Merge branch 'main' into v0.10.0
2 parents 050d26a + 3d9cea0 commit 09e8781

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Makefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ VCPKG_EMSDK_FLAGS=-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=$(EMSDK)/upstream/emscripten/
157157
WASM_COMPILE_TIME_COMMON_FLAGS=-DWASM_LOADABLE_EXTENSIONS=1 -DBUILD_EXTENSIONS_ONLY=1 -DSKIP_EXTENSIONS="parquet;json" $(VCPKG_EMSDK_FLAGS) -DDUCKDB_EXPLICIT_PLATFORM='${DUCKDB_PLATFORM}'
158158
WASM_CXX_MVP_FLAGS=
159159
WASM_CXX_EH_FLAGS=$(WASM_CXX_MVP_FLAGS) -fwasm-exceptions -DWEBDB_FAST_EXCEPTIONS=1
160-
WASM_CXX_THREADS_FLAGS=$(WASM_COMPILE_TIME_EH_FLAGS) -DWITH_WASM_THREADS=1 -DWITH_WASM_SIMD=1 -DWITH_WASM_BULK_MEMORY=1
160+
WASM_CXX_THREADS_FLAGS=$(WASM_COMPILE_TIME_EH_FLAGS) -DWITH_WASM_THREADS=1 -DWITH_WASM_SIMD=1 -DWITH_WASM_BULK_MEMORY=1 -DUSE_PTHREADS=1 -pthread
161161
WASM_LINK_TIME_FLAGS=-O3 -sSIDE_MODULE=2 -sEXPORTED_FUNCTIONS="_${EXT_NAME}_version,_${EXT_NAME}_init" ../../deps/local/lib/*.a
162162

163163
wasm_mvp:
@@ -174,6 +174,6 @@ wasm_eh:
174174

175175
wasm_threads:
176176
mkdir -p ./build/wasm_threads
177-
emcmake cmake $(GENERATOR) $(EXTENSION_FLAGS) $(WASM_COMPILE_TIME_COMMON_FLAGS) -Bbuild/wasm_threads -DCMAKE_CXX_FLAGS="$(WASM_CXX_THREADS_FLAGS) -DDUCKDB_CUSTOM_PLATFORM=wasm_threads" -S duckdb
177+
emcmake cmake $(GENERATOR) $(EXTENSION_FLAGS) $(WASM_COMPILE_TIME_COMMON_FLAGS) -Bbuild/wasm_threads -DCMAKE_CXX_FLAGS="$(WASM_CXX_THREADS_FLAGS) -DDUCKDB_CUSTOM_PLATFORM=wasm_threads" -DCMAKE_C_FLAGS="-pthread" -S duckdb
178178
emmake make -j8 -Cbuild/wasm_threads
179-
cd build/wasm_threads/extension/${EXT_NAME} && emcc $f -o ../../${EXT_NAME}.duckdb_extension.wasm ${EXT_NAME}.duckdb_extension.wasm.lib $(WASM_LINK_TIME_FLAGS)
179+
cd build/wasm_threads/extension/${EXT_NAME} && emcc $f -o ../../${EXT_NAME}.duckdb_extension.wasm ${EXT_NAME}.duckdb_extension.wasm.lib $(WASM_LINK_TIME_FLAGS) -sSHARED_MEMORY=1 -pthread

deps/CMakeLists.txt

+3-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ set(CMAKE_PROJ_FLAGS )
2828
set(CMAKE_GDAL_FLAGS )
2929
set(PATCH_NAME_ENDING )
3030
if (EMSCRIPTEN)
31-
set(CMAKE_FLAGS_POINTER_SIZE -DCMAKE_SIZEOF_VOID_P=4 -DCMAKE_SIZEOF_VOIDP=4)
31+
set(CMAKE_FLAGS_POINTER_SIZE -DCMAKE_SIZEOF_VOID_P=4 -DCMAKE_SIZEOF_VOIDP=4 -DCMAKE_C_FLAGS=-pthread -DCMAKE_CXX_FLAGS=-pthread)
3232
set(CMAKE_PROJ_FLAGS -DCMAKE_MODULE_PATH=${LOCAL_INSTALL_DIR}/lib/cmake -DSQLITE3_INCLUDE_DIR=${LOCAL_INSTALL_DIR}/include -DSQLITE3_LIBRARY=${LOCAL_INSTALL_DIR}/lib/libsqlite3.a)
3333
set(CMAKE_GDAL_FLAGS -DACCEPT_MISSING_LINUX_FS_HEADER=ON -DSIZEOF_INT=4 -DSIZEOF_UNSIGNED_LONG=4 -DSIZEOF_OFF_T=4 -DGEOS_DIR=${LOCAL_INSTALL_DIR}/lib/cmake/geos -DGeographicLib_DIR=${LOCAL_INSTALL_DIR}/lib/cmake/GeographicLib -DSQLITE3_LIBRARY=${LOCAL_INSTALL_DIR}/lib/libsqlite3.a)
3434
set(PATCH_NAME_ENDING _wasm)
@@ -154,6 +154,7 @@ ExternalProject_Add(
154154
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
155155
-DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES_PACKED}
156156
-DCMAKE_POSITION_INDEPENDENT_CODE=ON
157+
${CMAKE_FLAGS_POINTER_SIZE}
157158
# vcpkg options
158159
-DVCPKG_MANIFEST_DIR='${VCPKG_MANIFEST_DIR}'
159160
-DVCPKG_INSTALLED_DIR='${VCPKG_INSTALLED_DIR}'
@@ -208,6 +209,7 @@ ExternalProject_Add(
208209
-DCMAKE_PREFIX_PATH=${LOCAL_INSTALL_DIR}
209210
-DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES_PACKED}
210211
-DCMAKE_POSITION_INDEPENDENT_CODE=ON
212+
${CMAKE_FLAGS_POINTER_SIZE}
211213
# vcpkg options
212214
-DVCPKG_MANIFEST_DIR='${VCPKG_MANIFEST_DIR}'
213215
-DVCPKG_INSTALLED_DIR='${VCPKG_INSTALLED_DIR}'

0 commit comments

Comments
 (0)