Skip to content

Commit 1b0fe61

Browse files
committed
Fix issues with position spacing and GitHub link icon
1 parent 1d64ce0 commit 1b0fe61

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

dist/index.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/CurrentPosition.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ function sortItemsByDate<T>(items: T[], getDateProperty: {(item: T): string}) {
2525
export default function CurrentPosition(positions: PositionReadmeFragment[]) {
2626
const latestPosition = sortItemsByDate(positions, position => position.startDate)[0];
2727

28-
return `<img align="left" src="https://raw.githubusercontent.com/Merlin04/github-contentful-readme/main/business-24px.svg">${latestPosition.position} at&nbsp;
28+
return `<img align="left" src="https://raw.githubusercontent.com/Merlin04/github-contentful-readme/main/business-24px.svg">${latestPosition.position} at
2929
${latestPosition.companyUrl ? `<a href="${latestPosition.companyUrl}">${latestPosition.company}</a>` : latestPosition.company}`;
3030
}

src/components/ProjectCell.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ function generateImageTag(image: ProjectMediaFragment, maxHeight: number, contai
2626

2727
export default function ProjectCell(project: FeaturedProjectFragment, cellWidth: number) {
2828
return (
29-
`<h3>${project.url !== undefined ? (
29+
`<h3>${project.url ? (
3030
`<a href="${project.url}">${project.title}</a>`
31-
) : project.title }${project.codeUrl !== undefined ? (
31+
) : project.title }${project.codeUrl ? (
3232
`<a href="${project.codeUrl}"><img align="right" src="https://raw.githubusercontent.com/Merlin04/github-contentful-readme/main/github-24px.svg"></a>`
3333
) : ""}</h3>
3434
<p>${project.tagline}</p>

0 commit comments

Comments
 (0)