Increment version to 0.0.76 in pyproject.toml and update `markitdow…
#456
Conversation
…n` dependency to include all extras in `uv.lock` for enhanced functionality.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @MervinPraison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request increments the version of the praisonaiagents package from 0.0.75 to 0.0.76 in pyproject.toml and uv.lock. It also updates the markitdown dependency in pyproject.toml to include all extras (markitdown[all]) and reflects this change in uv.lock to ensure all markitdown features are available.
Highlights
- Version Increment: The package version has been bumped from 0.0.75 to 0.0.76 in both
pyproject.tomlanduv.lock. - Dependency Update: The
markitdowndependency is updated to include all extras (markitdown[all]) inpyproject.tomlanduv.lock.
Changelog
- src/praisonai-agents/pyproject.toml
- Incremented package version from 0.0.75 to 0.0.76 (line 7).
- Updated
markitdowndependency to include all extras:markitdown[all](line 31).
- src/praisonai-agents/uv.lock
- Incremented package version from 0.0.75 to 0.0.76 (line 1886).
- Updated
markitdowndependency to include all extras (line 1928).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A version ascends,
Features bloom, dependencies mend,
Code's garden thrives.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
PR Reviewer Guide 🔍(Review updated until commit c332346)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
✅ Deploy Preview for praisonai canceled.
|
WalkthroughThe Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CI Feedback 🧐(Feedback updated until commit c332346)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
There was a problem hiding this comment.
Code Review
The pull request increments the project version and updates a dependency to include all extras. The changes seem straightforward and well-documented in the PR description.
Summary of Findings
- Dependency Update: The
markitdowndependency was updated to include all extras (markitdown[all]). This enhancement should be verified to ensure it doesn't introduce any unexpected side effects or conflicts with other dependencies. - Version Increment: The project version was incremented from
0.0.75to0.0.76. Ensure that this version increment aligns with the project's versioning strategy and release process.
Merge Readiness
The pull request appears to be in good shape for merging, but it's crucial to verify that the dependency update doesn't introduce any regressions or conflicts. I am unable to approve this pull request, and recommend that others review and approve this code before merging. At a minimum, the high severity issue should be addressed before merging.
| @@ -1925,7 +1925,7 @@ requires-dist = [ | |||
| { name = "chromadb", marker = "extra == 'knowledge'", specifier = "==0.5.23" }, | |||
| { name = "chromadb", marker = "extra == 'memory'", specifier = ">=0.5.23" }, | |||
| { name = "litellm", marker = "extra == 'llm'", specifier = ">=1.50.0" }, | |||
| { name = "markitdown", marker = "extra == 'knowledge'" }, | |||
| { name = "markitdown", extras = ["all"], marker = "extra == 'knowledge'" }, | |||
There was a problem hiding this comment.
It's good to see the uv.lock file was updated, but it's important to verify that all the necessary dependencies and sub-dependencies were correctly resolved and locked. Consider running tests to ensure that the application functions as expected with the updated lockfile.
{ name = "markitdown", extras = ["all"], marker = "extra == 'knowledge'" },
| @@ -28,7 +28,7 @@ memory = [ | |||
| knowledge = [ | |||
| "mem0ai>=0.1.0", | |||
| "chromadb==0.5.23", | |||
| "markitdown", | |||
| "markitdown[all]", | |||
There was a problem hiding this comment.
Consider adding a comment explaining why all extras are needed for the markitdown dependency. This will help future developers understand the purpose of this change.
"markitdown[all]", # Includes all extras for enhanced markdown functionality
|
/ask what are the key changes |
Ask❓what are the key changes Answer:The key changes in this PR are:
These changes appear to be focused on version management and enhancing functionality by including all available features of the markitdown dependency. |
|
/review pyproject.toml and requirements.txt file |
|
Persistent review updated to latest commit c332346 |
User description
…n
dependency to include all extras inuv.lock` for enhanced functionality.PR Type
enhancement, dependencies
Description
Incremented project version to
0.0.76inpyproject.toml.Updated
markitdowndependency to include all extras (markitdown[all]).Improved dependency management for enhanced functionality.
Changes walkthrough 📝
pyproject.toml
Increment version and enhance `markitdown` dependencysrc/praisonai-agents/pyproject.toml
0.0.75to0.0.76.markitdowndependency tomarkitdown[all]for extendedfunctionality.
Summary by CodeRabbit