feat: transaction builder #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
reviewed
Feb 19, 2025
Co-authored-by: Charly Chevalier <charlyy.chevalier@gmail.com>
Co-authored-by: Charly Chevalier <charlyy.chevalier@gmail.com>
Co-authored-by: Charly Chevalier <charlyy.chevalier@gmail.com>
ccharly
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the transaction building mechanism by mimicking the BDK way of having a dynamic builder. The builder adds support for
unspendableUTXOs to remove them from the coin selection. It also adds theTxidandOutpointwrappers.In order to implement the builder, the wallet needs to be passed by reference in a mutable way. There is no way to directly pass the reference in
wasm-bindgenso we use aRefCellandRc.