New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add limitations to readme #32

Merged

darioAnongba merged 1 commit into MetaMask:main from riverKanies:feature/update-readme-limitations

Feb 19, 2025

Contributor

riverKanies commented Feb 19, 2025

Description

BDK team requested that we include more usage instructions directly in this repo so thate book-of-bdk can simply point to it for now.

This PR adds an appended version of the notes for the book example (which is still wip)

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing

New Features:

I've added tests for the new feature
I've added docs for the new feature

Bugfixes:

This pull request breaks the existing API
I've added tests to reproduce the issue which are now passing
I'm linking the issue being fixed by this PR


          feat: add limitations to readme

6f1f4d8

darioAnongba approved these changes

View reviewed changes

darioAnongba merged commit 86edef4 into MetaMask:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet