Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Broccoli(BROCCOLI) #1430

Merged
merged 17 commits into from
Feb 27, 2025
Merged

Add Broccoli(BROCCOLI) #1430

merged 17 commits into from
Feb 27, 2025

Conversation

Refdeveloper
Copy link
Contributor

@Refdeveloper Refdeveloper requested review from MRabenda and a team as code owners February 27, 2025 10:33
@MRabenda
Copy link
Collaborator

Hey @Refdeveloper - thank you for contribution, can you rename image file to have {adderess}.{extension} fromat?

@Refdeveloper
Copy link
Contributor Author

Hey @Refdeveloper - thank you for contribution, can you rename image file to have {adderess}.{extension} fromat?

Hello @MRabenda, I think I just did it, can you please check?

@MRabenda
Copy link
Collaborator

MRabenda commented Feb 27, 2025

Thanks that is ok, would you mind change icon/eip155:1 to icon/eip155:56 the same for metadata/eip155:1 to metadata/eip155:56

@Refdeveloper
Copy link
Contributor Author

Refdeveloper commented Feb 27, 2025

Thanks that is ok, would you mind change icon/eip155:1 to icon/eip155:56 the same for metadata/eip155:1 to metadata/eip155:56

Can you please guide me on how to do this? Would do
it directly before creating pull request but couldn't find the way :(

@MRabenda
Copy link
Collaborator

Create new folder and copy file

From metadata/eip155:1/0x12b4356c65340fb02cdff01293f95febb1512f3b.json to metadata/eip155:56/0x12b4356c65340fb02cdff01293f95febb1512f3b.json - the same for icon

@Refdeveloper
Copy link
Contributor Author

Refdeveloper commented Feb 27, 2025

I did it in the hard way haha, but i think i achieved. Please check. Also should i delete the other 2 from eip155:1 ?

@MRabenda
Copy link
Collaborator

Yes please delete eip155:1 version of files and we are good to merge

@Refdeveloper
Copy link
Contributor Author

I just deleted both and changed the json file to say the correct icon path now. Please check it out. Thank you.

MRabenda
MRabenda previously approved these changes Feb 27, 2025
@Refdeveloper
Copy link
Contributor Author

hey @MRabenda, one check seems to fail for some reason. let me know if i have to do something else. Thank you a lot.

@MRabenda
Copy link
Collaborator

Thank you for your contribution @Refdeveloper

@MRabenda MRabenda merged commit c0832b7 into MetaMask:master Feb 27, 2025
8 checks passed
@Refdeveloper
Copy link
Contributor Author

Thank you @MRabenda, while the pull request is approved i can't view the token into the default list or metamask swap yet, should we wait a bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants