Skip to content

Set-CsTenantFederationConfiguration - new AllowedTrialTenantDomains parameter docs #12355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

rhrivnak
Copy link
Contributor

@rhrivnak rhrivnak commented Nov 8, 2024

This PR contains documentation for new AllowedTrialTenantDomains parameter with examples of usage.

Adding documentation for AllowedTrialTenantDomains.
Ordering of examples and parameter sections changed.
AllowedTrialTenantDomains parameters docs improved.
Copy link

Learn Build status updates of commit 828012b:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Set-CsTenantFederationConfiguration.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@rhrivnak
Copy link
Contributor Author

rhrivnak commented Nov 8, 2024

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Contributor

@williamlooney williamlooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to adjust/update wording for -AllowedTrialTenantDomains notes.

AllowedTrialTenantDomains parameter docs changed to be more descriptive.
Copy link

Learn Build status updates of commit 03d50b6:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Set-CsTenantFederationConfiguration.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2e206fe:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Set-CsTenantFederationConfiguration.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@williamlooney williamlooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but, the text talks about what can be checked vs not.

Something like:

"Any domain in this list that belongs to a tenant with paid subscriptions will be ignored." us better.

AllowedTrialTenantDomains parameter docs adjusted.
Copy link

Learn Build status updates of commit 508e27d:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Set-CsTenantFederationConfiguration.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@michbrown-png michbrown-png added the Sign off The pull request is ready to be reviewed and merged by PubOps label Nov 12, 2024
Copy link

Learn Build status updates of commit 3913283:

💡 Validation status: suggestions

File Status Preview URL Details
teams/teams-ps/teams/Set-CsTenantFederationConfiguration.md 💡Suggestion View (teams-ps) Details

teams/teams-ps/teams/Set-CsTenantFederationConfiguration.md

  • Line 0, Column 0: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@padmagit77 padmagit77 self-assigned this Nov 12, 2024
@padmagit77 padmagit77 added the In review PubOps is reviewing the pull request label Nov 12, 2024
Added ms.date
Copy link

Learn Build status updates of commit 330ee81:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Set-CsTenantFederationConfiguration.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@padmagit77 padmagit77 added the PubOps fixes PubOps has fixed some issues in this PR. label Nov 12, 2024
@padmagit77 padmagit77 merged commit e6bcadd into MicrosoftDocs:main Nov 12, 2024
7 checks passed
Copy link
Contributor

@williamlooney williamlooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review PubOps is reviewing the pull request PubOps fixes PubOps has fixed some issues in this PR. Sign off The pull request is ready to be reviewed and merged by PubOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants