Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for items granted on player_redeemed_coupon #368

Open
tc-attilio opened this issue Nov 18, 2022 · 2 comments
Open

Wrong type for items granted on player_redeemed_coupon #368

tc-attilio opened this issue Nov 18, 2022 · 2 comments
Assignees
Labels
Health Triaged Triaged within product health

Comments

@tc-attilio
Copy link

tc-attilio commented Nov 18, 2022

Hi,

In player_redeemed_coupon, the items granted are contained in a property GrantedInventoryItems of type CouponGrantedInventoryItem. This in turn contains a property which I suppose should contain the list of items granted, but it's also of type CouponGrantedInventoryItem. I would expect a list of item instances, or a single instance since coupons do not support multiple grants.

Could you please double check and update the docs?

Thanks!


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@tc-attilio
Copy link
Author

After inspecting the event envelope, GrantedInventoryItems should be a list of CouponGrantedInventoryItem. Each CouponGrantedInventoryItem should have InstanceId, ItemId and CatalogVersion

@cybtachyon
Copy link
Contributor

Acknowledging issue, thanks!

@thomasgu thomasgu added this to the Product Health Q1 milestone Aug 4, 2023
@thomasgu thomasgu self-assigned this Oct 31, 2023
@thomasgu thomasgu added the Health Triaged Triaged within product health label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Health Triaged Triaged within product health
Projects
None yet
Development

No branches or pull requests

3 participants