Merge branch 'dev' into pla-1039-add-hyper-backgammon-variant

Author: JamesHeppell

.github/workflows/dependency-graph.yml

@@ -0,0 +1,17 @@
+name: Update Dependency Graph
+
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - dev #default branch of project
+
+jobs:
+  update-graph:
+    name: Update Dependency Graph
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: scalacenter/sbt-dependency-submission@v3
+        with:
+          working-directory: './'

src/main/scala/Clock.scala

@@ -669,7 +669,7 @@ case class ByoyomiClock(
     else {
       val player        = players(c)
       val timeUsed      = timestampFor(c).fold(Centis(0))(t =>
-        if (withGrace) (toNow(t) - (players(c).lag.quota atMost Centis(200))) nonNeg
+        if (withGrace) (toNow(t) - (player.lag.quota atMost Centis(200))) nonNeg
         else toNow(t)
       )
       val timeRemaining = player.remaining + player.periodsLeft * player.byoyomi
@@ -770,7 +770,8 @@ case class ByoyomiClock(
           if (usingByoyomi)
             updatePlayer(player) {
               _.setRemaining(
-                (remaining - moveTime) atLeast (if (switchClock) competitor.byoyomi
+                (remaining - moveTime) atLeast (if (!clockActive) Centis(0)
+                                                else if (switchClock) competitor.byoyomi
                                                 else timeRemainingAfterMove)
               )
                 .spendPeriods(periodSpan)

src/main/scala/samurai/Api.scala

@@ -3,8 +3,6 @@ package strategygames.samurai
 import com.joansala.game.oware.OwareGame
 import com.joansala.game.oware.OwareBoard
 
-import cats.implicits._
-
 import strategygames.Player
 import strategygames.samurai.format.FEN
 import strategygames.samurai.variant.Variant
@@ -177,9 +175,9 @@ object Api {
     lazy val gameOutcome: Int      = position.outcome()
     lazy val isRepetition: Boolean = position.isRepetition() && !allSeedsOnSameSide
 
-    lazy val allSeedsOnSameSide: Boolean = toPosition
-      .take(variant.boardSize.width)
-      .sum === 0 || toPosition.drop(variant.boardSize.width).take(variant.boardSize.width).sum === 0;
+    lazy val allSeedsOnSameSide: Boolean =
+      toPosition.take(variant.boardSize.width).sum == 0 ||
+        toPosition.drop(variant.boardSize.width).take(variant.boardSize.width).sum == 0
 
     val legalMoves: Array[Int] = {
       position.resetCursor()