chore: clean up Pos Uci Variant

Author: vincentfrochot

src/main/scala/abalone/Pos.scala

@@ -237,7 +237,7 @@ case class Pos private (index: Int) extends AnyVal {
   def piotrStr = piotr.toString
 
   def key                 = file.toString + rank.toString
-  def officialNotationKey = File(rank.index).getOrElse("").toString + "" + Rank(file.index).getOrElse("").toString
+  def officialNotationKey = s"${File(rank.index).getOrElse("")}${Rank(file.index).getOrElse("")}"
   override def toString   = officialNotationKey
 }
 

src/main/scala/abalone/format/Uci.scala

@@ -24,7 +24,7 @@ object Uci {
       promotion: Option[PromotableRole] = None
   ) extends Uci {
 
-    def keys = orig.officialNotationKey + dest.officialNotationKey
+    def keys = orig.key + dest.key
     def uci  = keys + promotionString
 
     def keysPiotr = orig.piotrStr + dest.piotrStr

src/main/scala/abalone/variant/Variant.scala

@@ -8,8 +8,6 @@ import strategygames.{ GameFamily, Player }
 import strategygames.abalone._
 import strategygames.abalone.format.FEN
 
-case class AbaloneName(val name: String)
-
 // Correctness depends on singletons for each variant ID
 abstract class Variant private[variant] (
     val id: Int,