503 abalone

[vincentfrochot]

No description provided.

[msomatt]

It might be good to have some extra parameter that indicates this isn't a regular 9x9

[vincentfrochot]

not sure what you suggested for that one, can you give me an example ?

[msomatt]

At the moment, all of our boards are regular square/rectangular. So when we say a board is of say Width 9 and Height 2, this means that all of the rows are of width 9.

This will remain true for a hexagonal board of the shape that is needed for the game Hex.

However, this won't be true for Abalone as each rows width is variable. So I was suggesting that we add an extra parameter (a boolean) to indicate this difference in shape. Not sure what to call it, but it would be false for all current boards and true for the Abalone board size.

I can't think of an obvious place where this new parameter must be used, but it could well be useful

[vincentfrochot]

let me know if you expect me to do it differently and if I should already consider applying the change to other Board files
Can't we just define something like "if this variable exists then the Board does not have a regular square size" ?
Would avoid modifying other Board.scala files 🤔

[msomatt]

if this variable exists then the Board does not have a regular square size
Yes exactly this.
I would make it a parameter of the BoardSize class. You could default it true as an input.
This would probably mean you need to edit the constructor of all BoardSize classes in other game logics (and wrapper layer) but thats fine. As its a default parameter it shouldn't require any other code changes.