Pla 982 add bestemshe

src/main/scala/GameCollection.scala

@@ -292,7 +292,7 @@ object GameFamily {
     def name              = "Amazons"
     def key               = "amazons"
     def gameLogic         = GameLogic.FairySF()
-    def hasFishnet        = true
+    def hasFishnet        = false
     def hasAnalysisBoard  = false
     def defaultVariant    = Variant.FairySF(strategygames.fairysf.variant.Amazons)
     def variants          = Variant.all(GameLogic.FairySF()).filter(_.gameFamily == this)

src/main/scala/fairysf/variant/Amazons.scala

@@ -28,7 +28,7 @@ case object Amazons
   override val switchPlayerAfterMove = false
 
   override def hasAnalysisBoard: Boolean = false
-  override def hasFishnet: Boolean       = true
+  override def hasFishnet: Boolean       = false
 
   // cache this rather than checking with the API everytime
   override def initialFen =

src/main/scala/togyzkumalak/Board.scala

@@ -80,7 +80,7 @@ object Board {
   }
 
   object BoardSize {
-    val all: List[BoardSize] = List(Dim9x2)
+    val all: List[BoardSize] = List(Dim9x2, Dim5x2)
   }
 
   case object Dim9x2
@@ -89,4 +89,10 @@ object Board {
         height = 2
       )
 
+  case object Dim5x2
+      extends BoardSize(
+        width = 5,
+        height = 2
+      )
+
 }

src/main/scala/togyzkumalak/File.scala

@@ -36,6 +36,6 @@ object File {
   val H = new File(7)
   val I = new File(8)
 
-  val all                     = List(A, B, C, D, E, F, G, H, I)
-  val allReversed: List[File] = all.reverse
+  val all                    = List(A, B, C, D, E, F, G, H, I)
+  def allByWidth(width: Int) = all.take(width)
 }

src/main/scala/togyzkumalak/Pos.scala

@@ -75,9 +75,15 @@ case class Pos private (index: Int) extends AnyVal {
   def piotr: Char = Piotr.lookup.get(index).getOrElse('?')
   def piotrStr    = piotr.toString
 
-  def player: Player = if (index < 9) Player.P1 else Player.P2
+  def player: Player = if (index < File.all.size) Player.P1 else Player.P2
 
-  def last: Boolean = (index + 1) % 9 == 0
+  def last(width: Int): Boolean =
+    if (rank.index == 0) (index + 1) % width == 0
+    else index == Pos.all.size - 1
+
+  def indexByWidth(width: Int): Int =
+    if (rank.index == 0) index
+    else index - (File.all.size - width) * 2
 
   def key               = file.toString + rank.toString
   override def toString = key
@@ -88,14 +94,17 @@ object Pos {
     if (0 <= index && index < File.all.size * Rank.all.size) Some(new Pos(index))
     else None
 
-  def apply(file: File, rank: Rank): Pos = new Pos(file.index + File.all.size * rank.index)
+  def apply(file: File, rank: Rank): Pos =
+    if (rank.index == 0) new Pos(file.index)
+    else new Pos(File.all.size * (rank.index + 1) - 1 - file.index)
 
   def at(x: Int, y: Int): Option[Pos] =
     if (0 <= x && x < File.all.size && 0 <= y && y < Rank.all.size)
       Some(new Pos(x + (File.all.size - x) * y))
     else None
 
-  def opposite(index: Int): Option[Pos] = apply(if (index < 9) index + 9 else index - 9)
+  def opposite(index: Int): Option[Pos] =
+    apply(if (index < File.all.size) index + File.all.size else index - File.all.size)
 
   def fromKey(key: String): Option[Pos] = allKeys get key
 
@@ -137,6 +146,8 @@ object Pos {
   // if adding new Pos check for use of Pos.all
   val all: List[Pos] = (0 to (File.all.size * Rank.all.size) - 1).map(new Pos(_)).toList
 
+  def allByWidth(width: Int): List[Pos] = all.filter(_.file.index < width)
+
   val allKeys: Map[String, Pos] = all
     .map { pos =>
       pos.key -> pos

src/main/scala/togyzkumalak/format/FEN.scala

@@ -1,7 +1,7 @@
 package strategygames.togyzkumalak.format
 
 import strategygames.Player
-import strategygames.togyzkumalak.{ Piece, PieceMap, Pos, Stone, Tuzdik }
+import strategygames.togyzkumalak.{ File, Piece, PieceMap, Pos, Stone, Tuzdik }
 
 final case class FEN(value: String) extends AnyVal {
 
@@ -24,7 +24,7 @@ final case class FEN(value: String) extends AnyVal {
   private def intFromFen(index: Int): Option[Int] =
     value.split(' ').lift(index).flatMap(_.toIntOption)
 
-  private def width: Int = 9
+  private def width: Int = mancalaStoneArray.size / 2
 
   def mancalaStoneArray: Array[Int] =
     (
@@ -34,9 +34,9 @@ final case class FEN(value: String) extends AnyVal {
     )
       .map(c =>
         c.toString() match {
-          case x if 1 to width map (_.toString) contains x => Array.fill(x.toInt)(0)
-          case x if x.length > 1                           => Array(c.dropRight(1).toInt)
-          case _                                           => Array(-1)
+          case x if 1 to File.all.size map (_.toString) contains x => Array.fill(x.toInt)(0)
+          case x if x.length > 1                                   => Array(c.dropRight(1).toInt)
+          case _                                                   => Array(-1)
         }
       )
       .flatten
@@ -46,8 +46,8 @@ final case class FEN(value: String) extends AnyVal {
     mancalaStoneArray.zipWithIndex
       .filterNot { case (s, _) => s == 0 }
       .map { case (stones, index) =>
-        Pos(index) -> (if (stones == -1) (Tuzdik, 1)
-                       else (Stone, stones))
+        Pos.allByWidth(width).lift(index) -> (if (stones == -1) (Tuzdik, 1)
+                                              else (Stone, stones))
       }
       .flatMap {
         case (Some(pos), (r, c)) if r == Tuzdik => Some((pos -> Tuple2(Piece(!pos.player, r), c)))

src/main/scala/togyzkumalak/format/Forsyth.scala

@@ -84,7 +84,7 @@ object Forsyth {
     var empty = 0
     for (y <- Rank.allReversed) {
       empty = 0
-      val files = if (y.index == 0) File.all else File.allReversed
+      val files = File.allByWidth(board.variant.boardSize.width)
       for (x <- files) {
         board(x, y) match {
           case None                 => empty = empty + 1

src/main/scala/togyzkumalak/variant/Bestemshe.scala

@@ -0,0 +1,47 @@
+package strategygames.togyzkumalak
+package variant
+
+import strategygames.togyzkumalak._
+import strategygames.{ GameFamily, Player }
+
+case object Bestemshe
+    extends Variant(
+      id = 2,
+      key = "bestemshe",
+      name = "Bestemshe",
+      standardInitialPosition = false,
+      boardSize = Board.Dim5x2
+    ) {
+
+  def gameFamily: GameFamily = GameFamily.Togyzkumalak()
+
+  def perfIcon: Char = ''
+  def perfId: Int    = 401
+
+  override def baseVariant: Boolean = false
+
+  override def canOfferDraw = false
+
+  // cache this rather than checking with the API everytime
+  override def initialFen =
+    format.FEN("5S,5S,5S,5S,5S/5S,5S,5S,5S,5S 0 0 S 1")
+
+  override def usesTuzdik = false
+
+  override def specialEnd(situation: Situation) =
+    (situation.board.history.score.p1 > 25) ||
+      (situation.board.history.score.p2 > 25) ||
+      (situation.moves.size == 0)
+
+  // shouldn't happen from starting fen as scores have to always be even so 25=25 is not possible
+  override def specialDraw(situation: Situation) =
+    situation.board.history.score.p1 == situation.board.history.score.p2
+
+  override def winner(situation: Situation): Option[Player] =
+    if (specialEnd(situation) && !specialDraw(situation)) {
+      if (situation.board.history.score.p1 > situation.board.history.score.p2)
+        Player.fromName("p1")
+      else Player.fromName("p2")
+    } else None
+
+}

src/main/scala/togyzkumalak/variant/Togyzkumalak.scala

@@ -24,7 +24,6 @@ case object Togyzkumalak
   override def initialFen =
     format.FEN("9S,9S,9S,9S,9S,9S,9S,9S,9S/9S,9S,9S,9S,9S,9S,9S,9S,9S 0 0 S 1")
 
-  // TODO check legalMoves.size == 0 condition
   override def specialEnd(situation: Situation) =
     (situation.board.history.score.p1 > 81) ||
       (situation.board.history.score.p2 > 81) ||

src/main/scala/togyzkumalak/variant/Variant.scala

@@ -47,52 +47,66 @@ abstract class Variant private[variant] (
 
   def startPlayer: Player = P1
 
+  def usesTuzdik: Boolean = true
+
   // looks like this is only to allow King to be a valid promotion piece
   // in just atomic, so can leave as true for now
   def isValidPromotion(@nowarn promotion: Option[PromotableRole]): Boolean = true
 
-  private def destFromOrig(pos: Pos, count: Int): Pos =
-    (if (count == 1) Pos((pos.index + 1) % 18)
-     else Pos((pos.index + count - 1)    % 18)) match {
+  private def destFromOrig(pos: Pos, count: Int, width: Int): Pos =
+    (if (count == 1) Pos.allByWidth(width).lift((pos.indexByWidth(width) + 1) % (width * 2))
+     else Pos.allByWidth(width).lift((pos.indexByWidth(width) + count - 1)    % (width * 2))) match {
       case Some(dest) => dest
-      case None       => sys.error(s"Invalid dest from orig(${pos.index}) in togyz move(${count})")
+      case None       => sys.error(s"Invalid dest from orig(${pos.index}) in togyz(${width}) move(${count})")
     }
 
   private lazy val emptyPieceMap: PieceMap =
-    Pos.all.map(pos => (pos, (Piece(pos.player, Stone), 0))).toMap
+    Pos.allByWidth(boardSize.width).map(pos => (pos, (Piece(pos.player, Stone), 0))).toMap
 
   private def pieceMapWithEmpties(pieces: PieceMap): PieceMap = emptyPieceMap.map {
     case (pos, _) if pieces.get(pos).nonEmpty => (pos -> pieces(pos))
     case piece                                => piece
   }
 
   private def stonesAfterMove(origStones: Int, thisStones: Int, origIndex: Int, thisIndex: Int): Int = {
-    val thisDiff = if (thisIndex < origIndex) thisIndex + 18 else thisIndex;
+    val thisDiff = if (thisIndex < origIndex) thisIndex + (boardSize.width * 2) else thisIndex;
     if (origStones == 1) {
       if (origIndex == thisIndex) 0
       else if (thisDiff - origIndex == 1) thisStones + 1
       else thisStones
     } else {
-      val remainder = if ((thisDiff - origIndex) < origStones % 18) 1 else 0;
+      val remainder = if ((thisDiff - origIndex) < origStones % (boardSize.width * 2)) 1 else 0;
       val remaining = if (origIndex == thisIndex) 0 else thisStones
-      remaining + (origStones / 18) + remainder
+      remaining + (origStones / (boardSize.width * 2)) + remainder
     }
   }
 
   def piecesAfterMove(pieces: PieceMap, orig: Pos, dest: Pos, oppTuzdik: Option[Pos]): PieceMap =
     pieceMapWithEmpties(pieces)
       .map {
         case (pos, posInfo) if posInfo._1.role != Tuzdik =>
-          (pos, (posInfo._1, stonesAfterMove(pieces(orig)._2, posInfo._2, orig.index, pos.index)))
+          (
+            pos,
+            (
+              posInfo._1,
+              stonesAfterMove(
+                pieces(orig)._2,
+                posInfo._2,
+                orig.indexByWidth(boardSize.width),
+                pos.indexByWidth(boardSize.width)
+              )
+            )
+          )
         case (pos, posInfo)                              => (pos, posInfo)
       }
       // now remove stones
       .map {
         case (pos, posInfo) if pos == dest && orig.player != dest.player && posInfo._2 % 2 == 0 =>
           (pos, (posInfo._1, 0))
-        case (pos, posInfo) if pos == dest && orig.player != dest.player && posInfo._2 == 3 && pieces.filter {
+        case (pos, posInfo)
+            if usesTuzdik && pos == dest && orig.player != dest.player && posInfo._2 == 3 && pieces.filter {
               case (pos2, posInfo2) => posInfo2._1.role == Tuzdik && pos2.player == dest.player
-            }.isEmpty && oppTuzdik != Pos.opposite(dest.index) && !dest.last =>
+            }.isEmpty && oppTuzdik != Pos.opposite(dest.index) && !dest.last(boardSize.width) =>
           (pos, (Piece(!pos.player, Tuzdik), 1))
         case (pos, posInfo) => (pos, posInfo)
       }
@@ -128,7 +142,7 @@ abstract class Variant private[variant] (
       }
       .map {
         case (pos, posInfo) => {
-          val dest = destFromOrig(pos, posInfo._2);
+          val dest = destFromOrig(pos, posInfo._2, boardSize.width);
           (
             pos,
             List(
@@ -208,7 +222,8 @@ abstract class Variant private[variant] (
 object Variant {
 
   lazy val all: List[Variant] = List(
-    Togyzkumalak
+    Togyzkumalak,
+    Bestemshe
   )
   val byId                    = all map { v =>
     (v.id, v)

src/test/scala/backgammon/BackgammonTest.scala

@@ -5,6 +5,7 @@ import org.specs2.matcher.ValidatedMatchers
 import org.specs2.mutable.Specification
 
 import strategygames.backgammon.format.Uci
+import strategygames.backgammon.variant.Variant
 
 class BackgammonTest extends Specification with ValidatedMatchers {
 
@@ -13,9 +14,13 @@ class BackgammonTest extends Specification with ValidatedMatchers {
       vg.flatMap { g => g.apply(action).map(_._1) }
     }
 
-  def playActionStrs(actionStrs: List[String], game: Option[Game] = None): Validated[String, Game] =
+  def playActionStrs(
+      actionStrs: List[String],
+      game: Option[Game] = None,
+      variant: Option[Variant] = None
+  ): Validated[String, Game] =
     playUciList(
-      game.getOrElse(Game.apply(variant.Backgammon)),
+      game.getOrElse(Game.apply(variant.getOrElse(Variant.default))),
       Uci.readList(actionStrs.mkString(" ")).getOrElse(List())
     )