validMoves and boardAfter #188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msomatt
reviewed
Oct 21, 2024
msomatt
reviewed
Oct 21, 2024
msomatt
reviewed
Oct 21, 2024
msomatt
reviewed
Oct 21, 2024
msomatt
reviewed
Oct 21, 2024
vincentfrochot
commented
Oct 23, 2024
vincentfrochot
commented
Oct 23, 2024
msomatt
reviewed
Oct 23, 2024
msomatt
reviewed
Oct 23, 2024
vincentfrochot
commented
Oct 23, 2024
msomatt
reviewed
Oct 24, 2024
msomatt
reviewed
Oct 24, 2024
msomatt
reviewed
Oct 24, 2024
- return empty List() instead of None before flattening when we are supposed to return a List overall - remove unnecessary use of a List - use map in case the inner code can only ever return something, e.g. : (x) => "a value whatever the value of x"
Also start a refacto of piecesAfterAction - needs more work to be done
- trigger draw by 3fold repetition - delegate to Move.finalizeAfter all the work except the pieceMap update which remain in Variant.boardAfter - improve Situation.piecesAfterAction codestyle - Replay.replayMove now works - remove notion of promotion - add more unit tests
use match case when working with Option: not using get anymore, when possible
vincentfrochot
force-pushed
the
pla-924-sg-variant-tests
branch
from
d18773e to
c75eea8
Compare
msomatt
reviewed
Oct 29, 2024
msomatt
reviewed
Oct 29, 2024
msomatt
reviewed
Oct 29, 2024
msomatt
reviewed
Oct 29, 2024
msomatt
reviewed
Oct 29, 2024
- In case we want Abalone to be a multiaction game, it would already be ready for trying it out - Also add a few notes for later
- update piecesAfterAction to fix the bug with side moves and remove remaining .get() - add tests specific to side moves - adapt package name and imports in test files in order to still be able to use .pp()
was there for debug purpose
remove Direction from moves creation parameters list in Variant switch to pair instead of triplet in possibleSideMoves as the direction is not used anymore later on
vincentfrochot
force-pushed
the
pla-924-sg-variant-tests
branch
from
9b8ccba to
98de331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.