Skip to content

Enable bypass of ip limitations via ENV in collector processing #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 21, 2025
Merged

Enable bypass of ip limitations via ENV in collector processing #3652

merged 12 commits into from
Apr 21, 2025

Conversation

timothycarambat
Copy link
Member

@timothycarambat timothycarambat commented Apr 15, 2025 •
edited
Loading

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #3625
connect #3626

What is in this change?

  • Enable bypassing for simple IP checks on web-scraping via a collector ENV for those who want to do this
  • Enabled by default
  • Set COLLECTOR_ALLOW_ANY_IP to any value in your env to enable this bypass.

Additional Information

Developer Validations

@timothycarambat timothycarambat changed the title Enable bypass of ip limitations via ENV in collector startup Enable bypass of ip limitations via ENV in collector processing Apr 15, 2025
@timothycarambat timothycarambat added the PR:needs review Needs review by core team label Apr 15, 2025
shatfield4
shatfield4 approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@shatfield4 shatfield4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timothycarambat timothycarambat added PR:Ready-to-merge PR has been reviewed by core team and is ready to merge and removed PR:needs review Needs review by core team labels Apr 15, 2025
@timothycarambat timothycarambat merged commit 1601eb9 into master Apr 21, 2025
1 check passed
@timothycarambat timothycarambat deleted the 3625-bypass-ip-check branch April 21, 2025 18:10
DoiDoi888

This comment was marked as off-topic.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoiDoi888 DoiDoi888 DoiDoi888 left review comments

@shatfield4 shatfield4 shatfield4 approved these changes

Assignees

@timothycarambat timothycarambat

Labels
PR:Ready-to-merge PR has been reviewed by core team and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Can't use upload-link endpoint on local network IPs
3 participants
@timothycarambat @shatfield4 @DoiDoi888