feat: added GtfsRiderCategoriesSchema #1989
Open
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit dc69b88 📊 Notices ComparisonNew Errors (146 out of 1821 datasets, ~8%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
Dropped Errors (1 out of 1821 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1821 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1821 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1821 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
@Sergiodero @skalexch I did some spot checks because the error % freaked me out - this looks like another case where Trillium's empty files are the culprit. This is good timing! I'll let them know and get their thoughts |
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 3b65cb7 📊 Notices ComparisonNew Errors (146 out of 1822 datasets, ~8%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
Dropped Errors (1 out of 1822 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1822 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1822 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1822 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
|
Hey @qcdyx! The one feed that we don't understand why it's returning an error is https://mobilitydatabase.org/feeds/mdb-258. It seems to include all required fields and should not return a |
emmambd
reviewed
Feb 26, 2025
| String riderCategoryName(); | ||
|
|
||
| @Required | ||
| GtfsRiderCategory isDefaultRiderCategory(); |
There was a problem hiding this comment.
@qcdyx @skalexch figured it out! It looks like this needs to be isDefaultFareCategory not isDefaultRiderCategory in order to match the spec: https://github.com/google/transit/pull/511/files#diff-3ecf0760eb54b4953728042a1e30586705dc2335807be94faae0de5829cd12a1R411 and make sure https://mobilitydatabase.org/feeds/mdb-258 doesn't trigger the error.
There was a problem hiding this comment.
Ok, it is rider_categories.is_default_rider_category in the requirement. Shall I proceed to make the change?
There was a problem hiding this comment.
Ah, I see what you mean from the requirements. Yes please - the spec is always the source of truth, so is_default_fare_category is the right field name.
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit d8646a4 📊 Notices ComparisonNew Errors (144 out of 1822 datasets, ~8%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
Dropped Errors (1 out of 1822 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1822 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1822 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1822 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
| Metric | Dataset ID | Reference (s) | Latest (s) | Difference (s) |
|---|---|---|---|---|
| Average | -- | 470.32 MiB | 462.48 MiB | ⬇️-7.85 MiB |
| Median | -- | 334.88 MiB | 335.92 MiB | ⬆️+1.04 MiB |
| Standard Deviation | -- | 792.39 MiB | 746.83 MiB | ⬇️-45.56 MiB |
| Minimum in References Reports | us-california-laguna-beach-transit-lbt-gtfs-16 | 39.60 MiB | 411.92 MiB | ⬆️+372.32 MiB |
| Maximum in Reference Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 10.94 GiB | 10.99 GiB | ⬆️+49.75 MiB |
| Minimum in Latest Reports | us-california-merced-county-transit-the-bus-gtfs-86 | 407.92 MiB | 40.29 MiB | ⬇️-367.63 MiB |
| Maximum in Latest Reports | gb-unknown-uk-aggregate-feed-gtfs-2014 | 10.94 GiB | 10.99 GiB | ⬆️+49.75 MiB |
|
Hey @qcdyx! One more issue here re: the spec: In the original requirements, it's specified the empty is a valid value for In looking at the Culver City Bus example where it's now returning a 
Can you add empty as a valid value? Once that's complete, this should be good for QA on the spec side. cc @skalexch @Sergiodero |
In other words, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1979
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything