Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fare_product_with_multiple_default_rider_categories #1980

Open
skalexch opened this issue Feb 18, 2025 · 0 comments
Open

Add fare_product_with_multiple_default_rider_categories #1980

skalexch opened this issue Feb 18, 2025 · 0 comments
Labels
new rule New rule to be added status: Ready An issue that is ready to be worked on.

Comments

@skalexch
Copy link

skalexch commented Feb 18, 2025

Describe the problem

We adopted rider categories. The PR will be merged soon.

Describe the new validation rule

Related spec language Rationale for rule Notice name to update or add Pseudologic Notice table columns Severity Notice description
rider_categories.rider_category_id, fare_products.rider_category_id, is_default_fare_category When multiple rider categories are eligible for a single fare product specified by a fare_product_id, there must be exactly one of these eligible rider categories indicated as the default rider category fare_product_with_multiple_default_rider_categories if rider_categories.txt does not exist: Do not trigger a notice and ignore subsequent checks
For each fare_product_id: If multiple rider_category_id are associated:
If more than one of these rider_category_id has is_default_fare_category ==1: Trigger Notice
FareProductId, CsvRowNumber1,CsvRowNumber2 (for the fare product), RiderCategoryId1,RiderCategoryId2 ERROR A fare product in fare_products.txt has more than one eligible default rider category from rider_categories.txt.

Sample GTFS datasets

http://developer.trimet.org/schedule/gtfs.zip

Severity

ERROR

Additional context

gtfs.org documentation: google/transit#511

@skalexch skalexch added new rule New rule to be added status: Needs triage Applied to all new issues labels Feb 18, 2025
@emmambd emmambd added this to the 7.0 Validator Release milestone Feb 19, 2025
@emmambd emmambd added status: Ready An issue that is ready to be worked on. and removed status: Needs triage Applied to all new issues labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new rule New rule to be added status: Ready An issue that is ready to be worked on.
Projects
None yet
Development

No branches or pull requests

2 participants