Add New Flex v2 Feeds (Brown County Heartland Express Otter Express, All Points Transit, Avon Transit, Blackhawk and Central City Tramway, Cripple Creek Transportation [SOURCES] #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmambd
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Looks good! 1 specific comment included, and 1 general comment: you don't need to include the provider name in the "name" field - you can just say "Flex v2 included". I wouldn't just say "Flex v2" since we know there are fixed routes in here as well as on-demand ones.
| "data_type": "gtfs", | ||
| "provider": "The Otter Express", | ||
| "name": "Otter Ecpress Medical Transportation Flex v2", | ||
| "feed_contact_email": "Kaylas@Productivemn.org", |
There was a problem hiding this comment.
@AlfredNwolisa Not sure where this feed contact email came from - it looks like the feed_info.txt has a trillium email
There was a problem hiding this comment.
@emmambd this was the email on otter express website. I will update it to trillium's.
There was a problem hiding this comment.
@emmambd updates done kind review
feed contact email updated to 'support@trilliumtransit.com'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@emmambd kindly review. This is the first batch of the Flex v2 feeds addition.