feat: new is_official tag for feeds #649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to use the new is_official attribute
…ary functions in representations.py. Added test case in test_operations.py for get_sources_by_is_official function - Passed.
…y_is_official, test_has_is_official for both GtfsScheduleSource and GtfsRealtimeSource. All passed.
|
|
|
|
|
Thanks for this great contribution @lawrencefan506! Our team will be taking a look shortly. |
davidgamez
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Hi @lawrencefan506, thanks for your contribution! Please update your branch with the latest from main and I added a minor comment before approving. Thanks again!
| @@ -124,7 +129,8 @@ def update_gtfs_realtime_source( | |||
| note (str, optional): Additional notes regarding the source. Defaults to None. | |||
| status (str, optional): The status of the GTFS Realtime source. Defaults to None. | |||
| features (list, optional): A list of features of the GTFS Realtime source. Defaults to None. | |||
|
|
|||
| s_official (str, optional): Flag indicating if the source comes from the agency itself or not. Defaults to None. | |||
There was a problem hiding this comment.
[picky]: fix typo
Suggested change
| s_official (str, optional): Flag indicating if the source comes from the agency itself or not. Defaults to None. | |
| is_official (str, optional): Flag indicating if the source comes from the agency itself or not. Defaults to None. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new optional tag called 'is_official' for feeds as requested in issue #356.
Changes:
schemas/gtfs_realtime_source_schema.jsonandschemas/gtfs_schedule_source_schema.jsonto include this tag.tools/representations.py, adding this tag to theSourceclass.tools/representations.py, ahas_is_officialmethod for theGtfsScheduleSourceandGtfsRealtimeSourceclasses and aget_sources_by_is_officialmethod for theSourcesCatalogclass.tools/tests/test_representations.pyfor each new method listed above. All passed locally.get_sources_by_is_officialmethod intools/operations.py.tools/tests/test_operations.pyfor the new method listed above. Passed locally.README.mdschemas to include this tag.