fix CI & drop EoL MongoDB < 4.4 #2887
Conversation
terencehonles
force-pushed
the
fix-ci
branch
6 times, most recently
from
acf3f9a to
6a72192
Compare
| MONGODB_6_0: "6.0.20" | ||
| MONGODB_7_0: "7.0.17" | ||
| MONGODB_8_0: "8.0.5" | ||
| MONGODB_6_0: "6.0.22" |
There was a problem hiding this comment.
bumping to their latest patch releases
| @@ -36,8 +33,6 @@ env: | |||
|
|
|||
| MAIN_PYTHON_VERSION: "3.9" | |||
|
|
|||
| MONGOSH: "2.4.2" # Needed for MongoDB 6.0+ | |||
There was a problem hiding this comment.
always installing mongosh since it's only not needed by MongoDB 4.4 and 5.0, but it works for > 4.2 and it simplifies the installation and checking.
.github/workflows/install_mongo.sh
Outdated
| if [[ "${MONGODB}" =~ ^(7.0|8.0) ]]; then | ||
| if [[ "$MONGODB" =~ ^(6.0|7.0|8.0) ]]; then | ||
| mongo_build="mongodb-linux-x86_64-ubuntu2204-${MONGODB}" | ||
| elif [[ "$MONGODB" =~ ^(4.4|5.0) ]]; then | ||
| mongo_build="mongodb-linux-x86_64-ubuntu2004-${MONGODB}" |
There was a problem hiding this comment.
like before, this still seems to work on 22.04, so I'm not going to try fixing/changing this
| fi | ||
| mongosh_build="mongosh-${MONGOSH}-linux-x64" | ||
| mongosh_tarball="${mongosh_build}.tgz" | ||
| mongosh_download_url="https://github.com/mongodb-js/mongosh/releases/download/v${MONGOSH}/${mongosh_tarball}" |
There was a problem hiding this comment.
The archived releases on https://www.mongodb.com/try/download/compass point me to github, so just inlining this
| echo >&2 "Creating mongo.path" | ||
| echo "export PATH='${mongodb_dir}/bin:${mongosh_dir}/bin:'"'$PATH' \ | ||
| | tee >&2 mongo.path |
There was a problem hiding this comment.
creating a ".path" file to make sure start_mongo is referring to the same binaries that this installation is referring to w/o having to duplicate the find logic.
This change fixes the CI by updating the ubuntu runner and drops EoL MongoDB versions below 4.4 which cannot be easily installed on Ubuntu 22.04.