Skip to content

fix CI & drop EoL MongoDB < 4.4 #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions .github/workflows/github-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,11 @@ on:
tags:
- 'v[0-9]+\.[0-9]+\.[0-9]+*'
env:
MONGODB_3_6: "3.6.23"
MONGODB_4_0: "4.0.28"
MONGODB_4_2: "4.2.25"
MONGODB_4_4: "4.4.29"
MONGODB_5_0: "5.0.31"
MONGODB_6_0: "6.0.20"
MONGODB_7_0: "7.0.17"
MONGODB_8_0: "8.0.5"
MONGODB_6_0: "6.0.22"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping to their latest patch releases

MONGODB_7_0: "7.0.19"
MONGODB_8_0: "8.0.9"

PYMONGO_3_12: "3.12.3"
PYMONGO_3_13: "3.13.0"
Expand All @@ -36,8 +33,6 @@ env:

MAIN_PYTHON_VERSION: "3.9"

MONGOSH: "2.4.2" # Needed for MongoDB 6.0+
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always installing mongosh since it's only not needed by MongoDB 4.4 and 5.0, but it works for > 4.2 and it simplifies the installation and checking.


jobs:
linting:
# Run pre-commit (https://pre-commit.com/)
Expand All @@ -55,17 +50,14 @@ jobs:
test:
# Test suite run against recent python versions
# and against a few combination of MongoDB and pymongo
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "pypy3.9", "pypy3.10"]
MONGODB: [$MONGODB_4_0]
MONGODB: [$MONGODB_4_4]
PYMONGO: [$PYMONGO_3_12]
include:
- python-version: "3.9"
MONGODB: $MONGODB_3_6
PYMONGO: $PYMONGO_3_12
- python-version: "3.9"
MONGODB: $MONGODB_4_4
PYMONGO: $PYMONGO_3_13
Expand Down Expand Up @@ -115,7 +107,6 @@ jobs:
- name: install mongo and ci dependencies
run: |
bash .github/workflows/install_mongo.sh ${{ matrix.MONGODB }}
bash .github/workflows/install_mongosh.sh ${{ matrix.MONGODB }} ${{ env.MONGOSH }}
bash .github/workflows/install_ci_python_dep.sh
bash .github/workflows/start_mongo.sh ${{ matrix.MONGODB }}
- name: tox dry-run (to pre-install venv)
Expand Down
84 changes: 57 additions & 27 deletions .github/workflows/install_mongo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,49 +4,79 @@ set -e # Exit immediately if a command exits with a non-zero status
set -u # Treat unset variables as an error

if [ "$#" -ne 1 ]; then
echo "Usage: $0 <mongodb-version>"
echo "Example: $0 8.0.5"
echo >&2 "Usage: $0 <mongodb-version>"
echo >&2 "Example: $0 8.0.5"
exit 1
fi

MONGODB="$1"
MONGOSH=2.5.1

# Determine build name based on version
if [[ "${MONGODB}" =~ ^(7.0|8.0) ]]; then
mongo_build="mongodb-linux-x86_64-ubuntu2004-${MONGODB}"
elif [[ "${MONGODB}" =~ ^(4.0|4.2|4.4|5.0|6.0) ]]; then
mongo_build="mongodb-linux-x86_64-ubuntu1804-${MONGODB}"
elif [[ "${MONGODB}" =~ ^3.6 ]]; then
mongo_build="mongodb-linux-x86_64-${MONGODB}"
if [[ "$MONGODB" =~ ^(6.0|7.0|8.0) ]]; then
mongodb_build="mongodb-linux-x86_64-ubuntu2204-${MONGODB}"
elif [[ "$MONGODB" =~ ^(4.4|5.0) ]]; then
mongodb_build="mongodb-linux-x86_64-ubuntu2004-${MONGODB}"
else
echo "Error: Unsupported MongoDB version: ${MONGODB}"
echo >&2 "Error: Unsupported MongoDB version: ${MONGODB}"
usage
fi

download_url="http://fastdl.mongodb.org/linux/${mongo_build}.tgz"
tarball="${mongo_build}.tgz"
mongodb_tarball="${mongodb_build}.tgz"
mongodb_download_url="http://fastdl.mongodb.org/linux/${mongodb_tarball}"

echo "Downloading MongoDB from ${download_url}..."
if ! wget --quiet "${download_url}"; then
echo "Error: Failed to download MongoDB."
exit 1
fi
mongosh_build="mongosh-${MONGOSH}-linux-x64"
mongosh_tarball="${mongosh_build}.tgz"
mongosh_download_url="https://github.com/mongodb-js/mongosh/releases/download/v${MONGOSH}/${mongosh_tarball}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The archived releases on https://www.mongodb.com/try/download/compass point me to github, so just inlining this


set -- \
MongoDB "$mongodb_tarball" "$mongodb_download_url" \
"MongoDB Shell" "$mongosh_tarball" "$mongosh_download_url"

while (( $# > 0 )) ; do
name="$1"
tarball="$2"
download_url="$3"
shift 3

echo >&2 "Downloading ${name} from ${download_url}..."
if ! wget --quiet "$download_url"; then
echo >&2 "Error: Failed to download ${name}."
exit 1
fi

echo "Extracting ${tarball}..."
if ! tar xzf "${tarball}"; then
echo "Error: Failed to extract ${tarball}"
echo >&2 "Extracting ${tarball}..."
if ! tar xzf "${tarball}"; then
echo >&2 "Error: Failed to extract ${tarball}"
exit 1
fi
done

mongodb_dir=$(find "${PWD}/" -type d -name "mongodb-linux-x86_64*" -print -quit)
if [ -z "$mongodb_dir" ]; then
echo >&2 "Error: Could not find MongoDB directory after extraction."
exit 1
fi

mongodb_dir=$(find "${PWD}/" -type d -name "mongodb-linux-x86_64*" | head -n 1)
if [ -z "${mongodb_dir}" ]; then
echo "Error: Could not find MongoDB directory after extraction."
exit 1
mongosh_dir=$(find "${PWD}/" -type d -name "$mongosh_build" -print -quit)
if [ ! -d "$mongosh_dir" ]; then
echo >&2 "Failed to find extracted mongosh directory."
rm -f "$TARBALL"
exit 1
fi

echo "MongoDB installed at: ${mongodb_dir}"
"${mongodb_dir}/bin/mongod" --version
echo >&2 "Creating mongo.path"
echo "export PATH='${mongodb_dir}/bin:${mongosh_dir}/bin:'"'$PATH' \
| tee >&2 mongo.path
Comment on lines +68 to +70
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creating a ".path" file to make sure start_mongo is referring to the same binaries that this installation is referring to w/o having to duplicate the find logic.


. mongo.path

echo >&2 "MongoDB is installed at: ${mongodb_dir}"
mongod >&2 --version

echo >&2 "MongoDB Shell is installed at: ${mongosh_dir}"
mongosh >&2 --version

# Cleanup
echo "Cleaning up..."
rm -f "${tarball}"
echo >&2 "Cleaning up..."
rm -f "$mongodb_tarball" "$mongosh_tarball"
56 changes: 0 additions & 56 deletions .github/workflows/install_mongosh.sh

This file was deleted.

15 changes: 7 additions & 8 deletions .github/workflows/start_mongo.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
#!/bin/bash

set -e # Exit immediately if a command exits with a non-zero status
set -u # Treat unset variables as an error

. mongo.path

MONGODB=$1

mongodb_dir=$(find ${PWD}/ -type d -name "mongodb-linux-x86_64*")
mongodb_dir=$(find ${PWD}/ -type d -name "mongodb-linux-x86_64*" -print -quit)

mkdir $mongodb_dir/data

Expand All @@ -15,12 +20,6 @@ if [ "$MAJOR" -gt 3 ] || ([ "$MAJOR" -eq 3 ] && [ "$MINOR" -ge 8 ]); then
args+=(--setParameter maxTransactionLockRequestTimeoutMillis=1000)
fi

$mongodb_dir/bin/mongod "${args[@]}"

if [ "$MAJOR" -lt 6 ]; then
mongo --verbose --eval "rs.initiate()"
mongo --quiet --eval "rs.status().ok"
else
mongod "${args[@]}"
mongosh --verbose --eval "rs.initiate()"
mongosh --quiet --eval "rs.status().ok"
fi
8 changes: 4 additions & 4 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ an `API reference <https://mongoengine-odm.readthedocs.io/apireference.html>`_.

Supported MongoDB Versions
==========================
MongoEngine is currently tested against MongoDB v3.6, v4.0, v4.4, v5.0, v6.0, v7.0 and v8.0. Future versions
should be supported as well, but aren't actively tested at the moment. Make
sure to open an issue or submit a pull request if you experience any problems
with a more recent MongoDB versions.
MongoEngine is currently tested against MongoDB v4.4, v5.0, v6.0, v7.0 and
v8.0. Future versions should be supported as well, but aren't actively tested
at the moment. Make sure to open an issue or submit a pull request if you
experience any problems with a more recent MongoDB versions.

Installation
============
Expand Down