Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Suite Iteration 2 #13508

Open
wants to merge 7 commits into
base: prototype
Choose a base branch
from

Conversation

dlopezvsr
Copy link
Collaborator

@dlopezvsr dlopezvsr commented Feb 16, 2025

Description

This PR includes:

  • djlint added to CI pipeline to validate formatting of django templates. This command is executed under "Run linting" job.
  • Leverage of Factories - unittests were updated to use factories created for profiles and blogs (BlogIndexPageFactory, BlogPageFactory, and ProfileFactory) instead of creating pages directly from the model.
  • Tests cases were updated and in some of them simplified.
  • "Run Unittests" Job was added to CI pipeline to run tests on every commit.
  • __init__.py file added inside tests folder of each app for correct initialization.

Related PRs/issues: https://mozilla-hub.atlassian.net/browse/TP1-1615

Tests

  • Pull this branch TP1-1615-test-suite-2-django-formatting inside of your prototype repository.
  • Run python3 manage.py test .
  • Make sure all test passed.
  • Also confirm you can properly execute djlint . --check and djlint . --reformat
  • Validate "Run Unittests" Job was properly triggered inside this PR.

┆Issue is synchronized with this Jira Story

@dlopezvsr dlopezvsr self-assigned this Feb 16, 2025
@dlopezvsr dlopezvsr marked this pull request as ready for review February 18, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant