Rename 'handler' to '_handler'

Author: LondonClass

pygame_gui/elements/ui_button.py

@@ -135,15 +135,15 @@ def __init__(self, relative_rect: Union[pygame.Rect, Tuple[float, float], pygame
 
         self.state_transitions = {}
 
-        self.handler = {}
+        self._handler = {}
         if command is not None:
             if callable(command):
                 self.bind(UI_BUTTON_PRESSED, command)
             else:
                 for key, value in command.items():
                     self.bind(key, value)
 
-        if UI_BUTTON_DOUBLE_CLICKED in self.handler:
+        if UI_BUTTON_DOUBLE_CLICKED in self._handler:
             self.allow_double_clicks = True
 
         self.rebuild_from_changed_theme_data()
@@ -368,15 +368,15 @@ def bind(self, event:int, function:Callable = None):
 
         """
         if function is None:
-            self.handler.pop(event, None)
+            self._handler.pop(event, None)
             return
 
         if callable(function):
             num_params = len(signature(function).parameters)
             if num_params == 1:
-                self.handler[event] = function
+                self._handler[event] = function
             elif num_params == 0:
-                self.handler[event] = lambda _:function()
+                self._handler[event] = lambda _:function()
             else:
                 raise ValueError("Button command function signatures can have 0 or 1 parameter. "
                                  "If one parameter is set it will contain data for the id of the mouse button used "
@@ -397,8 +397,8 @@ def on_button_event(self, event:int, data:Dict[str, Any]=None):
         if data is None:
             data = {}
 
-        if event in self.handler:
-            self.handler[event](data)
+        if event in self._handler:
+            self._handler[event](data)
         else:
             # old event to remove in 0.8.0
             event_data = {'user_type': OldType(event),

tests/test_elements/test_ui_button.py

@@ -465,7 +465,7 @@ def test_function(data):
                           manager=default_ui_manager,
                           command=test_function)
 
-        assert button.handler[pygame_gui.UI_BUTTON_PRESSED] == test_function
+        assert button._handler[pygame_gui.UI_BUTTON_PRESSED] == test_function
 
         assert not button_clicked
         # process a mouse button down event
@@ -498,13 +498,13 @@ def test_function(data):
                           tool_tip_text="This is a test of the button's tool tip functionality.",
                           manager=default_ui_manager)
 
-        assert pygame_gui.UI_BUTTON_PRESSED not in button.handler
+        assert pygame_gui.UI_BUTTON_PRESSED not in button._handler
 
         button.bind(pygame_gui.UI_BUTTON_PRESSED, test_function)
-        assert button.handler[pygame_gui.UI_BUTTON_PRESSED] == test_function
+        assert button._handler[pygame_gui.UI_BUTTON_PRESSED] == test_function
 
         button.bind(pygame_gui.UI_BUTTON_PRESSED, None)
-        assert pygame_gui.UI_BUTTON_PRESSED not in button.handler
+        assert pygame_gui.UI_BUTTON_PRESSED not in button._handler
 
         with pytest.raises(TypeError, match="Button command function must be callable"):
             button.bind(pygame_gui.UI_BUTTON_PRESSED, "non-callable")
@@ -537,9 +537,9 @@ def test_function2(data):
                           manager=default_ui_manager,
                           command=command_dict)
 
-        assert button.handler[pygame_gui.UI_BUTTON_START_PRESS] == test_function # not 
-        assert button.handler[pygame_gui.UI_BUTTON_PRESSED] == test_function2
-        assert pygame_gui.UI_BUTTON_DOUBLE_CLICKED not in button.handler
+        assert button._handler[pygame_gui.UI_BUTTON_START_PRESS] == test_function # not 
+        assert button._handler[pygame_gui.UI_BUTTON_PRESSED] == test_function2
+        assert pygame_gui.UI_BUTTON_DOUBLE_CLICKED not in button._handler
 
         assert not button_start_press
         button.on_button_event(pygame_gui.UI_BUTTON_START_PRESS, {'mouse_button':1})