Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code quality #672

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

General code quality #672

wants to merge 7 commits into from

Conversation

MyreMylar
Copy link
Owner

@MyreMylar MyreMylar commented Mar 2, 2025

General code quality and maintenance via tooling:

  1. Sourcery recommendations
  2. Pylint recommendations
  3. flake8 recommendations
  4. mypy recommendations
  5. Ruff formatting
  6. Update to latest pygame ce release
  7. Remove Python 3.8 support

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 92.03704% with 215 lines in your changes missing coverage. Please review.

Project coverage is 95.65%. Comparing base (09b051e) to head (005f27e).

Files with missing lines Patch % Lines
pygame_gui/core/text/text_box_layout.py 86.09% 42 Missing ⚠️
pygame_gui/core/utility.py 55.26% 34 Missing ⚠️
pygame_gui/core/layered_gui_group.py 79.23% 27 Missing ⚠️
pygame_gui/elements/ui_auto_resizing_container.py 50.98% 25 Missing ⚠️
pygame_gui/core/ui_appearance_theme.py 93.86% 16 Missing ⚠️
pygame_gui/core/text/html_parser.py 87.96% 13 Missing ⚠️
pygame_gui/core/text/text_box_layout_row.py 90.98% 11 Missing ⚠️
pygame_gui/core/colour_parser.py 81.81% 10 Missing ⚠️
pygame_gui/core/text/text_line_chunk.py 93.24% 10 Missing ⚠️
pygame_gui/core/drawable_shapes/drawable_shape.py 97.43% 4 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   95.77%   95.65%   -0.13%     
==========================================
  Files          90       91       +1     
  Lines       14105    14074      -31     
==========================================
- Hits        13509    13462      -47     
- Misses        596      612      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant