-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github workflow: Fix python link error on macOS #862
Conversation
marking as a draft until I get the workflow to complete successfully. |
Can we consider moving to one source of truth, and use the ansible repo to install all the needed libraries rather then a different approach for CI here? I am willing to work with you to (try) to accomplish that if it makes sense? |
I'm not opposed to going down that path. On the unofficial macOS CI chain I already do something similar for both macports and homebrew I will note the following comment was added to the workflow code: This leads me to believe that not using ansible was intentional |
I'll also note the issue I'm struggling with currently won't be fixed by ansible. The issue is an underlying homebrew python issue. Some of the homebew packages have upgraded to python3.12 but not all. This leads to a "brew link" issue where both python3.12 and python3.11 try to generate symlinks to ${HB_PREFIX}/bin/python3 etc. Another issue is that homebrew's runners have a broken python3.12 installed that requires updating. This version does not clean up all of the symlinks generated when installed (e.g. 2to3-3.12). This breaks the upgrade with a similar link issue. In reality, we could just wait out homebrew and github fixing these issues upstream. |
Good to see for that a fix is being worked on, as my PR is having this problem. |
Finally got through the link issues. Hopefully I can submit another PR thats backs some of this out in a number of weeks. |
@garybuhrmaster - I'm still happy to work with you on an ansible based approach in another PR (assuming that's a direction the mythtv devs would like us to go). |
dang it - more python conflicts on hombrew. Hoping to have this cleaned up (again) shortly. |
Homebrew has multiple versions of python which occasionally step on each other. Add the overwrite flag in the install process to explicity oveverwrite old links. Additionally add a call to brew upgrade to handle issues where new packages require updating already installed ones.
Ubuntu 20.04 only supports qt 5.12, deprecate the runner now that qt 5.15 is the new minimumally support version Additionally, bump the version of checkout and cache to the latest
Three successful CI checks in a row. I hope this is finally ready. |
Homebrew recently shifted to python3.12 as the default python on some
but not all versions of macOS. This fix resolves a package linking
issue experienced when installing python based packages.
Checklist